From: Bart Van Assche <bvanassche@acm.org>
To: ed.tsai@mediatek.com, Peter Wang <peter.wang@mediatek.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Stanley Jhu <chu.stanley@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: linux-scsi@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ufs: host: mediatek: Add VCC on delay for stability
Date: Thu, 5 Mar 2026 06:20:49 -0600 [thread overview]
Message-ID: <f298d3f3-1382-478d-87f2-ae9b212001da@acm.org> (raw)
In-Reply-To: <20260305083610.2672344-3-ed.tsai@mediatek.com>
On 3/5/26 2:29 AM, ed.tsai@mediatek.com wrote:
> Introduced a delay after enabling UFS5 VCC for MT6995 to ensure
> voltage stability before refclk activation.
Patch descriptions should use the imperative mood (Introduced ->
Introduce).
> + /*
> + * Add a delay after enable UFS5 VCC to ensure the voltage is
> + * stable before the refclk enable.
> + */
after enable -> after enabling
refclk enable -> refclk is enabled
Otherwise this patch looks good to me.
Thanks,
Bart.
prev parent reply other threads:[~2026-03-05 12:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260305083610.2672344-1-ed.tsai@mediatek.com>
2026-03-05 8:29 ` [PATCH 1/2] ufs: core: Add quriks for VCC ramp-up delay ed.tsai
2026-03-05 12:24 ` Bart Van Assche
2026-03-06 0:19 ` Ed Tsai (蔡宗軒)
2026-03-06 2:15 ` Bart Van Assche
2026-03-06 2:16 ` Bart Van Assche
2026-03-05 8:29 ` [PATCH 2/2] ufs: host: mediatek: Add VCC on delay for stability ed.tsai
2026-03-05 12:20 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f298d3f3-1382-478d-87f2-ae9b212001da@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=chu.stanley@gmail.com \
--cc=ed.tsai@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox