From: Can Guo <cang@codeaurora.org>
To: Asutosh Das <asutoshd@codeaurora.org>
Cc: Bean Huo <huobean@gmail.com>,
alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] scsi: ufs: change ufshcd_comp_devman_upiu() to ufshcd_compose_devman_upiu()
Date: Fri, 14 Aug 2020 17:29:04 +0800 [thread overview]
Message-ID: <f4a9c3a1147bb03a876d541d1e637976@codeaurora.org> (raw)
In-Reply-To: <20200813155515.GB25655@asutoshd-linux1.qualcomm.com>
On 2020-08-13 23:55, Asutosh Das wrote:
> On Wed, Aug 12 2020 at 07:37 -0700, Bean Huo wrote:
>> From: Bean Huo <beanhuo@micron.com>
>>
>> ufshcd_comp_devman_upiu() alwasy make me confuse that it is a request
>> completion calling function. Change it to
>> ufshcd_compose_devman_upiu().
>>
>> Signed-off-by: Bean Huo <beanhuo@micron.com>
>> Acked-by: Avri Altman <avri.altman@wdc.com>
>
> Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
Reviewed-by: Can Guo <cang@codeaurora.org>
>
>> ---
>> drivers/scsi/ufs/ufshcd.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>> index 5f09cda7b21c..e3663b85e8ee 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -2391,12 +2391,13 @@ static inline void
>> ufshcd_prepare_utp_nop_upiu(struct ufshcd_lrb *lrbp)
>> }
>>
>> /**
>> - * ufshcd_comp_devman_upiu - UFS Protocol Information Unit(UPIU)
>> + * ufshcd_compose_devman_upiu - UFS Protocol Information Unit(UPIU)
>> * for Device Management Purposes
>> * @hba: per adapter instance
>> * @lrbp: pointer to local reference block
>> */
>> -static int ufshcd_comp_devman_upiu(struct ufs_hba *hba, struct
>> ufshcd_lrb *lrbp)
>> +static int ufshcd_compose_devman_upiu(struct ufs_hba *hba,
>> + struct ufshcd_lrb *lrbp)
>> {
>> u8 upiu_flags;
>> int ret = 0;
>> @@ -2590,7 +2591,7 @@ static int ufshcd_compose_dev_cmd(struct ufs_hba
>> *hba,
>> ufshcd_prepare_lrbp_crypto(NULL, lrbp);
>> hba->dev_cmd.type = cmd_type;
>>
>> - return ufshcd_comp_devman_upiu(hba, lrbp);
>> + return ufshcd_compose_devman_upiu(hba, lrbp);
>> }
>>
>> static int
>> -- 2.17.1
>>
next prev parent reply other threads:[~2020-08-14 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 14:37 [PATCH v2 0/2] make UFS dev_cmd more readable Bean Huo
2020-08-12 14:37 ` [PATCH v2 1/2] scsi: ufs: change ufshcd_comp_devman_upiu() to ufshcd_compose_devman_upiu() Bean Huo
2020-08-13 15:55 ` Asutosh Das
2020-08-14 9:29 ` Can Guo [this message]
2020-08-12 14:37 ` [PATCH v2 2/2] scsi: ufs: remove several redundant goto statements Bean Huo
2020-08-13 15:52 ` Asutosh Das
2020-08-14 9:52 ` Bean Huo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4a9c3a1147bb03a876d541d1e637976@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=huobean@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox