From: Hannes Reinecke <hare@suse.de>
To: Karan Tilak Kumar <kartilak@cisco.com>, sebaddel@cisco.com
Cc: arulponn@cisco.com, djhawar@cisco.com, gcboffa@cisco.com,
mkai2@cisco.com, satishkh@cisco.com, aeasi@cisco.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 01/14] scsi: fnic: Replace shost_printk with dev_info/dev_err
Date: Mon, 21 Oct 2024 08:34:18 +0200 [thread overview]
Message-ID: <f6ecfef4-a880-493a-92a7-9be2d02555c8@suse.de> (raw)
In-Reply-To: <20241018161409.4442-2-kartilak@cisco.com>
On 10/18/24 18:13, Karan Tilak Kumar wrote:
> Sending host information to shost_printk
> prior to host initialization in fnic is unnecessary.
> Replace shost_printk and a printk prior to this
> initialization with dev_info and dev_err accordingly.
>
> Reviewed-by: Sesidhar Baddela <sebaddel@cisco.com>
> Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>
> Reviewed-by: Gian Carlo Boffa <gcboffa@cisco.com>
> Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
> ---
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich
next prev parent reply other threads:[~2024-10-21 6:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 16:13 [PATCH v5 00/14] Introduce support for Fabric Discovery and Karan Tilak Kumar
2024-10-18 16:13 ` [PATCH v5 01/14] scsi: fnic: Replace shost_printk with dev_info/dev_err Karan Tilak Kumar
2024-10-21 6:34 ` Hannes Reinecke [this message]
2024-10-18 16:13 ` [PATCH v5 02/14] scsi: fnic: Add headers and definitions for FDLS Karan Tilak Kumar
2024-10-21 6:33 ` Hannes Reinecke
2024-10-21 23:44 ` Karan Tilak Kumar (kartilak)
2024-10-18 16:13 ` [PATCH v5 03/14] scsi: fnic: Add support for fabric based solicited requests and responses Karan Tilak Kumar
2024-10-21 7:16 ` Hannes Reinecke
2024-10-22 0:03 ` Karan Tilak Kumar (kartilak)
2024-10-18 16:13 ` [PATCH v5 04/14] scsi: fnic: Add support for target " Karan Tilak Kumar
2024-10-24 7:28 ` Hannes Reinecke
2024-10-29 0:37 ` Karan Tilak Kumar (kartilak)
2024-10-18 16:14 ` [PATCH v5 05/14] scsi: fnic: Add support for unsolicited " Karan Tilak Kumar
2024-10-24 7:13 ` Hannes Reinecke
2024-10-29 0:42 ` Karan Tilak Kumar (kartilak)
2024-10-18 16:14 ` [PATCH v5 06/14] scsi: fnic: Add and integrate support for FDMI Karan Tilak Kumar
2024-10-24 7:32 ` Hannes Reinecke
2024-10-29 0:48 ` Karan Tilak Kumar (kartilak)
2024-10-18 16:14 ` [PATCH v5 07/14] scsi: fnic: Add and integrate support for FIP Karan Tilak Kumar
2024-10-18 16:14 ` [PATCH v5 08/14] scsi: fnic: Add functionality in fnic to support FDLS Karan Tilak Kumar
2024-10-18 16:14 ` [PATCH v5 09/14] scsi: fnic: Modify IO path to use FDLS Karan Tilak Kumar
2024-10-20 17:28 ` kernel test robot
2024-10-24 7:04 ` Hannes Reinecke
2024-10-29 0:54 ` Karan Tilak Kumar (kartilak)
2024-11-20 0:03 ` Karan Tilak Kumar (kartilak)
2024-10-18 16:14 ` [PATCH v5 10/14] scsi: fnic: Modify fnic interfaces " Karan Tilak Kumar
2024-10-18 16:14 ` [PATCH v5 11/14] scsi: fnic: Add stats and related functionality Karan Tilak Kumar
2024-10-18 16:14 ` [PATCH v5 12/14] scsi: fnic: Code cleanup Karan Tilak Kumar
2024-10-18 16:14 ` [PATCH v5 13/14] scsi: fnic: Add support to handle port channel RSCN Karan Tilak Kumar
2024-10-18 16:14 ` [PATCH v5 14/14] scsi: fnic: Increment driver version Karan Tilak Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6ecfef4-a880-493a-92a7-9be2d02555c8@suse.de \
--to=hare@suse.de \
--cc=aeasi@cisco.com \
--cc=arulponn@cisco.com \
--cc=djhawar@cisco.com \
--cc=gcboffa@cisco.com \
--cc=jejb@linux.ibm.com \
--cc=kartilak@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mkai2@cisco.com \
--cc=satishkh@cisco.com \
--cc=sebaddel@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox