From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B42F2F28FF for ; Mon, 23 Mar 2026 09:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257886; cv=none; b=hp5L4ZP9inYFwPI4q+vpRzF2A1oeml5iHXLV7OjLSgPx2DOhoaIXI5ntuzm0nZPS4JrTEBYvqTpywGyOu3VLRmmgDbUfYSlp9bojje57r2o1SiKftubm0uiBalWihKDfxG8OHf9+TKDK4e+Jr0FaVYAktWpk6lRonLa0tKFJ0tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774257886; c=relaxed/simple; bh=agJiL7CSHQDoONnfJoEWCiV5NgfjV0/hO6yZH4JKDmA=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=F5vIKCEm09RUV3fxuDoWmEW3krl/grnDXUols4NVtSkFrf7Zldb5WJYYJmbKeaT17HrdhK/EyNp6DBeghsWb7BPw4KBZqmjYsuMXjBnhM/YYygKe+aMvvjfatCXAz2S3uMhrIViMmPvwcEimTpYZuRf5OrydlRCzlbL6X1KWR1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k95jdctW; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k95jdctW" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-439b9b1900bso1785410f8f.1 for ; Mon, 23 Mar 2026 02:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774257883; x=1774862683; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=agJiL7CSHQDoONnfJoEWCiV5NgfjV0/hO6yZH4JKDmA=; b=k95jdctWO7wdLvPVv8y/yOOxkuzIgcI/KhriKZd+fSQxAKIWgHIK2irvTRdqie3Y5V N8qMYObKv7hCYMSFGdZV49RtvQFFHoYvxPpt7yoklzvctS1eyf6ijzmz4+VAMF16DkmA qyTe+4RTOtbhb2fx9xnqc1RJ7cB7+cZRFKpk2qbDYVaqyESnj2AkhuHjM5MaTyr4Asyp fQ3M9q5NCKII5qNAF9LIhn+yf5jzY99LqpSYowmX6bRj+ejvNVYMbWIMP1PbmZyCAKFr jtC/RUED9iZLVRgCnpkfP1KiCusoJlzhO4lgfbABaOOUTb51npfF16uiuFHwdjBnPluf /rsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774257883; x=1774862683; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=agJiL7CSHQDoONnfJoEWCiV5NgfjV0/hO6yZH4JKDmA=; b=fqTzN/IfbAIH53aryvn/jTKi71AJ0X8YgOMGTJdrJzCK0RbvUapWyQrpApHJPMG7X+ hEE7J3wLuLWbQ9/qm2t2v/Y78Qbs9J3xI2WMQYUdeHl/vRnEvI31DOXbd4tMqncpq4XY +Jpj5qOtLcEeWTMP33j19d5jfuIl5I59Kfx77zuO78s/zqogKn7yPvszMxEvmbhhhh53 0nw+pDrAx1McH6ddJl29hZSwgE/CaOq6RsQpef21i9oc6pqNsGEMvRXY19E72nMSnujE 14I9M31L2bq+nazmQqhlac/PqZz36bKR9yszqvyoSJTl7TpLTr8JVxQvDUk+k9oWKw3+ 2Yvg== X-Gm-Message-State: AOJu0Ywv5kGHLPhkxf5970YyMftvvLxm52vCZGhBZisipHP1CbLTMLQY oKA+SEMtaf0Tu+etzH54dp+UEagy292DvJY8JhlU1woK4NMypFfLJb5C X-Gm-Gg: ATEYQzzpYRyxPE53IO8iJXS8f2bmW4JOjZgUHB14XGAsnE4fcvFvK55bary03Ekrf2r DHjFAVXX7F2Rsmn76QWIHfkMilqUxJSwuMP5a1udcEz+G30yYzyOYM1mCLiknsBbn6DIiA8O/dU VEyETJtHQFajlTHoJ7hOebPmzBiglvZATR7+N/4CHrjxb2O+GJwGkBFIBJn8gr5DO2V/+HjmJrU MGYoDc2S5ioEWNCGqlUdiUSvvKRuU+6vUotlA3XXP07URvhBClcgLfb6rEqpBKyIEUd9Bky4hxq 7/NlwWXqTr0XMFjXeEBZQW9G3La3nelNb7L42Oq/U7EiPmRVTJWP/tms5l19LR+84AB9RCq3YfH eXpaQRzoGOVsbovuHA3n1cR6LZYgxdrk4tP6pfaQzelzmFzsODN2IQgO+AiJBkhqUmgm5QzqwRG 4OsssjuyCXv7gwE7SPWfbuvsSL7Q== X-Received: by 2002:a05:6000:2486:b0:43b:4e01:4aab with SMTP id ffacd0b85a97d-43b642812a5mr17199047f8f.37.1774257883326; Mon, 23 Mar 2026 02:24:43 -0700 (PDT) Received: from [10.176.235.211] ([137.201.254.43]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b64711f58sm28577645f8f.29.2026.03.23.02.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2026 02:24:42 -0700 (PDT) Message-ID: Subject: Re: [PATCH v4 11/12] scsi: ufs: ufs-qcom: Implement vops apply_tx_eqtr_settings() From: Bean Huo To: Can Guo , avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, "James E.J. Bottomley" , "open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER..." , open list Date: Mon, 23 Mar 2026 10:24:40 +0100 In-Reply-To: <20260321031021.1722459-12-can.guo@oss.qualcomm.com> References: <20260321031021.1722459-1-can.guo@oss.qualcomm.com> <20260321031021.1722459-12-can.guo@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2.1 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-03-20 at 20:10 -0700, Can Guo wrote: > On some platforms, when Host Software triggers TX Equalization Training, > HW does not take TX EQTR settings programmed in PA_TxEQTRSetting, instead > HW takes TX EQTR settings from PA_TxEQG1Setting. Implement vops > apply_tx_eqtr_setting() to work around it by programming TX EQTR settings > to PA_TxEQG1Setting during TX EQTR procedure. >=20 > Signed-off-by: Can Guo Reviewed-by: Bean Huo