From: Adrian Hunter <adrian.hunter@intel.com>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "James E . J . Bottomley" <jejb@linux.ibm.com>,
Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: ufs-pci: Add support for Intel Arrow Lake
Date: Wed, 14 Jun 2023 07:54:27 +0300 [thread overview]
Message-ID: <f7e5a3d9-3caa-e75d-5069-3763d3ca8951@intel.com> (raw)
In-Reply-To: <c3b42f98-31f8-39f4-4540-cccf0bfe31cd@acm.org>
On 13/06/23 21:22, Bart Van Assche wrote:
> On 6/13/23 10:03, Adrian Hunter wrote:
>> Add PCI ID to support Intel Arrow Lake, same as MTL.
>
> The patch looks good to me but the "same as MTL" text in the patch description looks confusing to me?
The code change is using the same driver data as MTL:
diff --git a/drivers/ufs/host/ufshcd-pci.c b/drivers/ufs/host/ufshcd-pci.c
index 38276dac8e52..cf3987773051 100644
--- a/drivers/ufs/host/ufshcd-pci.c
+++ b/drivers/ufs/host/ufshcd-pci.c
@@ -599,6 +599,7 @@ static const struct pci_device_id ufshcd_pci_tbl[] = {
{ PCI_VDEVICE(INTEL, 0x54FF), (kernel_ulong_t)&ufs_intel_adl_hba_vops },
{ PCI_VDEVICE(INTEL, 0x7E47), (kernel_ulong_t)&ufs_intel_mtl_hba_vops },
{ PCI_VDEVICE(INTEL, 0xA847), (kernel_ulong_t)&ufs_intel_mtl_hba_vops },
+ { PCI_VDEVICE(INTEL, 0x7747), (kernel_ulong_t)&ufs_intel_mtl_hba_vops }, <--- here
{ } /* terminate list */
};
MTL is Meteor Lake. The abbreviation is not unheard of in
commit messages. A web search for Intel MTL brings up the answer.
And there is this earlier patch to the same code:
commit 4049f7acef3eb37c1ea0df45f3ffc29404f4e708
Author: Adrian Hunter <adrian.hunter@intel.com>
Date: Mon Apr 4 08:50:38 2022 +0300
scsi: ufs: ufs-pci: Add support for Intel MTL
Add PCI ID and callbacks to support Intel Meteor Lake (MTL).
Link: https://lore.kernel.org/r/20220404055038.2208051-1-adrian.hunter@intel.com
Cc: stable@vger.kernel.org # v5.15+
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
next prev parent reply other threads:[~2023-06-14 4:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 17:03 [PATCH] scsi: ufs: ufs-pci: Add support for Intel Arrow Lake Adrian Hunter
2023-06-13 18:22 ` Bart Van Assche
2023-06-14 4:54 ` Adrian Hunter [this message]
2023-06-14 18:40 ` Bart Van Assche
2023-06-15 1:55 ` Martin K. Petersen
2023-06-22 1:26 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7e5a3d9-3caa-e75d-5069-3763d3ca8951@intel.com \
--to=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox