Re: [PATCH] scsi: Remember if a device is an ATA device

[Damien Le Moal <dlemoal@kernel.org>]

On 6/7/25 06:30, Igor Pylypiv wrote:
> On Fri, Jun 06, 2025 at 02:28:44PM +0900, Damien Le Moal wrote:
>> scsi_add_lun() tests the device vendor string of SCSI devices to detect
>> if a SCSI device is in fact an ATA device, in order to correctly handle
>> SATL power management. The function scsi_cdl_enable() also requires
>> knowing if a SCSI device is an ATA device to control the state of the
>> device CDL feature but this function does that by testing for the
>> presence of the VPD page 89h (ATA INFORMATION page).
>>
>> Simplify these different methods by adding the is_ata field to struct
>> scsi_device to remember that a SCSI device is in fact an ATA one based
>> on the device vendor name test. This filed can also allow low level
>> SCSI host adapter drivers to take special actions for ATA devices
>> (e.g. to better handle ATA NCQ errors).
> 
> It looks like we can also simplify the WRITE SAME disablement logic?
> 
> https://github.com/torvalds/linux/blob/master/drivers/scsi/sd.c#L3466-L3474

Indeed. Will add that in v2.


-- 
Damien Le Moal
Western Digital Research