From: David Laight <David.Laight@ACULAB.COM>
To: "'Martin K. Petersen'" <martin.petersen@oracle.com>,
Ranjan Kumar <ranjan.kumar@broadcom.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"sathya.prakash@broadcom.com" <sathya.prakash@broadcom.com>,
"sreekanth.reddy@broadcom.com" <sreekanth.reddy@broadcom.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v3 1/2] Perform additional retries if Doorbell read returns 0
Date: Wed, 9 Aug 2023 08:23:46 +0000 [thread overview]
Message-ID: <f89c7dea130842c4bb0089bd2d5a07d9@AcuMS.aculab.com> (raw)
In-Reply-To: <yq1a5v1ja8a.fsf@ca-mkp.ca.oracle.com>
From: Martin K. Petersen
> Sent: 09 August 2023 02:26
>
>
> Hi Ranjan,
>
> > But for few registers zero may be a valid value and we don’t want
> > those registers to get penalized with 30 read retries where 1/3 reads
> > would have sufficed.
>
> If 0 is a valid register value you'll end up always doing 3 retries
> before returning. Even if the first register reads were "successful".
> Peculiar!
Looks like the correct solution is to completely disable the BMC.
It clearly isn't compatible with using the driver as well.
If that isn't possible is seems it needs to be marked BROKEN :-)
Much like the main ethernet interface on my Ivy bridge i7.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-08-09 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 11:25 [PATCH v3 0/2] mpt3sas: Additional retries when reading specific registers Ranjan Kumar
2023-07-26 11:25 ` [PATCH v3 1/2] Perform additional retries if Doorbell read returns 0 Ranjan Kumar
2023-07-31 17:54 ` Martin K. Petersen
2023-08-03 8:16 ` Ranjan Kumar
2023-08-08 2:37 ` Martin K. Petersen
2023-08-08 7:12 ` Ranjan Kumar
2023-08-09 1:25 ` Martin K. Petersen
2023-08-09 8:23 ` David Laight [this message]
2023-08-10 5:44 ` Ranjan Kumar
2023-07-26 11:25 ` [PATCH v3 2/2] mpt3sas: Removing volatile qualifier Ranjan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f89c7dea130842c4bb0089bd2d5a07d9@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ranjan.kumar@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox