Re: [PATCH 13/26] null_blk: Do not request ELEVATOR_F_ZBD_SEQ_WRITE elevator feature

Hannes Reinecke
2024-02-04T12:31:37Z

On 2/2/24 15:30, Damien Le Moal wrote:
> With zone write plugging enabled at the block layer level, any zone
> device can only ever see at most a single write operation per zone.
> There is thus no need to request a block scheduler with strick per-zone
> sequential write ordering control through the ELEVATOR_F_ZBD_SEQ_WRITE
> feature. Removing this allows using a zoned null_blk device with any
> scheduler, including "none".
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> drivers/block/null_blk/zoned.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/null_blk/zoned.c b/drivers/block/null_blk/zoned.c
> index 6f5e0994862e..f2cb6da0dd0d 100644
> --- a/drivers/block/null_blk/zoned.c
> +++ b/drivers/block/null_blk/zoned.c
> @@ -161,7 +161,6 @@ int null_register_zoned_dev(struct nullb *nullb)
>
> disk_set_zoned(nullb->disk);
> blk_queue_flag_set(QUEUE_FLAG_ZONE_RESETALL, q);
> - blk_queue_required_elevator_features(q, ELEVATOR_F_ZBD_SEQ_WRITE);
> blk_queue_chunk_sectors(q, dev->zone_size_sects);
> nullb->disk->nr_zones = bdev_nr_zones(nullb->disk->part0);
> blk_queue_max_zone_append_sectors(q, dev->zone_size_sects);
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich