From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.g.garry@oracle.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Marco Elver <elver@google.com>,
linux-scsi@vger.kernel.org, Jianzhou Zhao <luckd0g@163.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Dongdong Hao <doubled@leap-io-kernel.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
Chandrakanth patil <chandrakanth.patil@broadcom.com>,
Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Ranjan Kumar <ranjan.kumar@broadcom.com>,
Nilesh Javali <njavali@marvell.com>,
Manish Rangankar <mrangankar@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH v7 5/6] scsi: core: Protect host state changes with the host lock
Date: Fri, 14 Aug 2026 08:41:42 -0700 [thread overview]
Message-ID: <f91c7df9-3534-4ec8-a6b6-417577bc22ad@acm.org> (raw)
In-Reply-To: <3731591a-f495-488a-bbe6-96f4ec2acb78@oracle.com>
On 8/14/26 7:59 AM, John Garry wrote:
> with my changes in https://lore.kernel.org/linux-scsi/
> yq15x1dtp3r.fsf@mail.kernel.org/T/
> #m064c12513575565cc08afa15738215b98bcca142 on top of this series, I
> notice that the following 2x forms of annotation are compliant for the
> context analysis checking:
>
> __must_hold(shost->host_lock)
> __must_hold(&shost->host_lock)
This is consistent with my observations - it seems like Clang accepts
both forms. Marco, do you perhaps know whether this is a bug or a
feature? I couldn't find the answer to this question in
https://clang.llvm.org/docs/ThreadSafetyAnalysis.html.
Thanks,
Bart.
next prev parent reply other threads:[~2026-08-14 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 22:49 [PATCH v7 0/6] Enable context analysis in the SCSI core and UFS driver Bart Van Assche
2026-08-07 22:49 ` [PATCH v7 1/6] ufs: core: Set task state before io_schedule_timeout() Bart Van Assche
2026-08-07 22:49 ` [PATCH v7 2/6] ufs: core: Enable context analysis Bart Van Assche
2026-08-07 22:49 ` [PATCH v7 3/6] scsi: core: Pass the SCSI host pointer directly to scanning functions Bart Van Assche
2026-08-07 22:49 ` [PATCH v7 4/6] scsi: core: Add lock context annotations Bart Van Assche
2026-08-07 22:49 ` [PATCH v7 5/6] scsi: core: Protect host state changes with the host lock Bart Van Assche
2026-08-11 11:21 ` John Garry
2026-08-14 14:59 ` John Garry
2026-08-14 15:41 ` Bart Van Assche [this message]
2026-08-17 22:58 ` Marco Elver
2026-08-07 22:49 ` [PATCH v7 6/6] scsi: core: Enable context analysis Bart Van Assche
2026-08-10 15:35 ` John Garry
2026-08-14 14:55 ` John Garry
2026-08-14 15:42 ` Bart Van Assche
2026-08-14 2:20 ` [PATCH v7 0/6] Enable context analysis in the SCSI core and UFS driver Martin K. Petersen (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f91c7df9-3534-4ec8-a6b6-417577bc22ad@acm.org \
--to=bvanassche@acm.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=doubled@leap-io-kernel.com \
--cc=elver@google.com \
--cc=john.g.garry@oracle.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=luckd0g@163.com \
--cc=martin.petersen@oracle.com \
--cc=mrangankar@marvell.com \
--cc=njavali@marvell.com \
--cc=ranjan.kumar@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox