From: Bart Van Assche <bvanassche@acm.org>
To: "Bean Huo (beanhuo)" <beanhuo@micron.com>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"pedrom.sousa@synopsys.com" <pedrom.sousa@synopsys.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
"cang@codeaurora.org" <cang@codeaurora.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v1 2/2] scsi: ufs: fix potential bug which ends in system hang-up
Date: Tue, 12 Nov 2019 08:41:20 -0800 [thread overview]
Message-ID: <f923772d-2105-e2b2-8503-4e87fd1bc180@acm.org> (raw)
In-Reply-To: <BN7PR08MB5684BD2FEE5153F7AF96F146DB770@BN7PR08MB5684.namprd08.prod.outlook.com>
On 11/11/19 4:22 PM, Bean Huo (beanhuo) wrote:
>
> Bean Huo <beanhuo@micron.com>
>
> In function __ufshcd_query_descriptor(), in the event of an error
> happening, we directly goto out_unlock, and forget to invaliate
> hba->dev_cmd.query.descriptor pointer. Thus results in this pointer
> still validity in ufshcd_copy_query_response() for other query requests
> which go through ufshcd_exec_raw_upiu_cmd(). This will cuases __memcpy()
> crash and system hangs up, log shows as below:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
prev parent reply other threads:[~2019-11-12 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 0:22 [RESEND PATCH v1 2/2] scsi: ufs: fix potential bug which ends in system hang-up Bean Huo (beanhuo)
2019-11-12 16:41 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f923772d-2105-e2b2-8503-4e87fd1bc180@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pedrom.sousa@synopsys.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox