Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Takashi Iwai <tiwai@suse.de>,
	"James E . J . Bottomley" <jejb@linux.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 7/8] scsi: core: Use scnprintf() for avoiding potential buffer overflow
Date: Wed, 11 Mar 2020 08:12:42 -0700	[thread overview]
Message-ID: <facacb36-2f60-e1ee-b3df-b66a2ba76744@acm.org> (raw)
In-Reply-To: <20200311091630.22565-8-tiwai@suse.de>

On 3/11/20 2:16 AM, Takashi Iwai wrote:
> Since snprintf() returns the would-be-output size instead of the
> actual output size, the succeeding calls may go beyond the given
> buffer limit.  Fix it by replacing with scnprintf().

Reviewed-by: Bart van Assche <bvanassche@acm.org>

  reply	other threads:[~2020-03-11 15:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  9:16 [PATCH 0/8] scsi: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-11  9:16 ` [PATCH 1/8] scsi: aacraid: " Takashi Iwai
2020-03-13  5:47   ` Balsundar.P
2020-03-11  9:16 ` [PATCH 2/8] scsi: be2iscsi: " Takashi Iwai
2020-03-11  9:16 ` [PATCH 3/8] scsi: fnic: " Takashi Iwai
2020-03-11  9:16 ` [PATCH 4/8] scsi: gdth: " Takashi Iwai
2020-03-11  9:16 ` [PATCH 5/8] scsi: ipr: " Takashi Iwai
2020-03-11  9:16 ` [PATCH 6/8] scsi: megaraid_sas: " Takashi Iwai
2020-03-11  9:16 ` [PATCH 7/8] scsi: core: " Takashi Iwai
2020-03-11 15:12   ` Bart Van Assche [this message]
2020-03-12  9:25   ` John Garry
2020-03-12 11:40     ` Takashi Iwai
2020-03-11  9:16 ` [PATCH 8/8] scsi: smartpqi: " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=facacb36-2f60-e1ee-b3df-b66a2ba76744@acm.org \
    --to=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox