From: Bean Huo <huobean@gmail.com>
To: daejun7.park@samsung.com, Greg KH <gregkh@linuxfoundation.org>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
ALIM AKHTAR <alim.akhtar@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
JinHwan Park <jh.i.park@samsung.com>,
SEUNGUK SHIN <seunguk.shin@samsung.com>,
Sung-Jun Park <sungjun07.park@samsung.com>,
yongmyung lee <ymhungry.lee@samsung.com>,
Jinyoung CHOI <j-young.choi@samsung.com>,
BoRam Shin <boram.shin@samsung.com>
Subject: Re: [PATCH v25 4/4] scsi: ufs: Add HPB 2.0 support
Date: Tue, 02 Mar 2021 13:49:47 +0100 [thread overview]
Message-ID: <fb70bf48fab65474bf2f15a436852ccf9a3db026.camel@gmail.com> (raw)
In-Reply-To: <20210226073525epcms2p5e7ddd6e92b2f76b2b3dcded49f8ff256@epcms2p5>
On Fri, 2021-02-26 at 16:35 +0900, Daejun Park wrote:
> +static void ufshpb_set_unmap_cmd(unsigned char *cdb, struct
> ufshpb_region *rgn)
> +{
> + cdb[0] = UFSHPB_WRITE_BUFFER;
> + cdb[1] = rgn ? UFSHPB_WRITE_BUFFER_INACT_SINGLE_ID :
> + UFSHPB_WRITE_BUFFER_INACT_ALL_ID;
Here is wrong,
Valid HPB Region is (0 ~ (Ceiling( Region size calculated by
bHPBRegionSize )- 1) ). how do you know the region==0 is not
a single normal region?
Bean
> + if (rgn)
> + put_unaligned_be16(rgn->rgn_idx, &cdb[2]);
> + cdb[9] = 0x00;
> +}
next prev parent reply other threads:[~2021-03-02 19:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210226073233epcms2p80fca2dffabea03143a9414838f757633@epcms2p8>
2021-02-26 7:32 ` [PATCH v25 0/4] scsi: ufs: Add Host Performance Booster Support Daejun Park
2021-02-26 7:33 ` [PATCH v25 1/4] scsi: ufs: Introduce HPB feature Daejun Park
2021-02-26 7:34 ` [PATCH v25 2/4] scsi: ufs: L2P map management for HPB read Daejun Park
2021-02-26 7:34 ` [PATCH v25 3/4] scsi: ufs: Prepare HPB read for cached sub-region Daejun Park
2021-02-26 7:35 ` [PATCH v25 4/4] scsi: ufs: Add HPB 2.0 support Daejun Park
2021-03-02 12:49 ` Bean Huo [this message]
2021-03-02 13:15 ` Avri Altman
2021-03-02 14:32 ` Bean Huo
2021-03-02 13:02 ` Bean Huo
2021-03-03 2:31 ` Daejun Park
2021-03-02 14:27 ` Bean Huo
2021-03-03 2:32 ` Daejun Park
2021-03-03 4:05 ` Can Guo
2021-03-03 4:58 ` Daejun Park
2021-03-03 4:31 ` Can Guo
2021-03-03 4:59 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb70bf48fab65474bf2f15a436852ccf9a3db026.camel@gmail.com \
--to=huobean@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=boram.shin@samsung.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=j-young.choi@samsung.com \
--cc=javier.gonz@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=jh.i.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=seunguk.shin@samsung.com \
--cc=stanley.chu@mediatek.com \
--cc=sungjun07.park@samsung.com \
--cc=ymhungry.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox