From: Bart Van Assche <bvanassche@acm.org>
To: "Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Peter Wang <peter.wang@mediatek.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Avri Altman <avri.altman@wdc.com>,
Andrew Halaney <ahalaney@redhat.com>,
Bean Huo <beanhuo@micron.com>
Subject: Re: [PATCH v4 3/4] scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to analyze
Date: Fri, 13 Sep 2024 10:55:28 -0700 [thread overview]
Message-ID: <fbbb8d00-2b70-403a-98cb-55ca0dba1d7f@acm.org> (raw)
In-Reply-To: <c4ce91f3-6724-03eb-ed72-0215c8992e0c@quicinc.com>
On 9/13/24 12:31 AM, Bao D. Nguyen wrote:
> On 9/12/2024 3:30 PM, Bart Van Assche wrote:
>> if (ufshcd_is_auto_hibern8_error(hba, intr_status))
>> hba->errors |= (UFSHCD_UIC_HIBERN8_MASK & intr_status);
>
> Hi Bart, while you are at it, there are extra parenthesis here too.
Agreed, but since of the one-change-per-patch rule I'd like to keep that
change out of this patch.
Thanks,
Bart.
next prev parent reply other threads:[~2024-09-13 17:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 22:30 [PATCH v4 0/4] Clean up the UFS driver UIC code Bart Van Assche
2024-09-12 22:30 ` [PATCH v4 1/4] scsi: ufs: core: Improve the struct ufs_hba documentation Bart Van Assche
2024-09-13 7:08 ` Bao D. Nguyen
2024-09-12 22:30 ` [PATCH v4 2/4] scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to read Bart Van Assche
2024-09-13 7:09 ` Bao D. Nguyen
2024-09-12 22:30 ` [PATCH v4 3/4] scsi: ufs: core: Make ufshcd_uic_cmd_compl() easier to analyze Bart Van Assche
2024-09-13 7:06 ` Peter Wang (王信友)
2024-09-13 7:31 ` Bao D. Nguyen
2024-09-13 17:55 ` Bart Van Assche [this message]
2024-09-12 22:30 ` [PATCH v4 4/4] scsi: ufs: core: Always initialize the UIC done completion Bart Van Assche
2024-10-04 1:36 ` [PATCH v4 0/4] Clean up the UFS driver UIC code Martin K. Petersen
2024-10-16 2:40 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbbb8d00-2b70-403a-98cb-55ca0dba1d7f@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=ahalaney@redhat.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox