Re: [PATCH 5/5] scsi_transport_iscsi: Declare local symbols static

[Johannes Thumshirn <jthumshirn@suse.de>]

On 2016-03-30 20:28, Bart Van Assche wrote:
> Avoid that building with W=1 causes gcc to report warnings about
> symbols that have not been declared.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
> ---
>  drivers/scsi/scsi_transport_iscsi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_transport_iscsi.c
> b/drivers/scsi/scsi_transport_iscsi.c
> index dff7413..c169fa1 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -1009,7 +1009,7 @@ static void iscsi_flashnode_sess_release(struct
> device *dev)
>  	kfree(fnode_sess);
>  }
> 
> -struct device_type iscsi_flashnode_sess_dev_type = {
> +static struct device_type iscsi_flashnode_sess_dev_type = {
>  	.name = "iscsi_flashnode_sess_dev_type",
>  	.groups = iscsi_flashnode_sess_attr_groups,
>  	.release = iscsi_flashnode_sess_release,
> @@ -1195,13 +1195,13 @@ static void
> iscsi_flashnode_conn_release(struct device *dev)
>  	kfree(fnode_conn);
>  }
> 
> -struct device_type iscsi_flashnode_conn_dev_type = {
> +static struct device_type iscsi_flashnode_conn_dev_type = {
>  	.name = "iscsi_flashnode_conn_dev_type",
>  	.groups = iscsi_flashnode_conn_attr_groups,
>  	.release = iscsi_flashnode_conn_release,
>  };
> 
> -struct bus_type iscsi_flashnode_bus;
> +static struct bus_type iscsi_flashnode_bus;
> 
>  int iscsi_flashnode_bus_match(struct device *dev,
>  				     struct device_driver *drv)
> @@ -1212,7 +1212,7 @@ int iscsi_flashnode_bus_match(struct device *dev,
>  }
>  EXPORT_SYMBOL_GPL(iscsi_flashnode_bus_match);
> 
> -struct bus_type iscsi_flashnode_bus = {
> +static struct bus_type iscsi_flashnode_bus = {
>  	.name = "iscsi_flashnode",
>  	.match = &iscsi_flashnode_bus_match,
>  };

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>