Re: [PATCH] scsi_debug: Make CRC_T10DIF support optional

[John Garry <john.g.garry@oracle.com>]

On 01/03/2024 16:30, Bart Van Assche wrote:
>>> Not all scsi_debug users need data integrity support. Hence modify the
>>> scsi_debug driver such that it becomes possible to build this driver
>>> without data integrity support.
>>>
>>> Cc: Douglas Gilbert<dgilbert@interlog.com>
>>> Signed-off-by: Bart Van Assche<bvanassche@acm.org>
>>> ---
>>>   drivers/scsi/Kconfig                          |   2 +-
>>>   drivers/scsi/Makefile                         |   2 +
>>>   drivers/scsi/scsi_debug-dif.h                 |  65 +++++
>>>   drivers/scsi/scsi_debug_dif.c                 | 224 +++++++++++++++
>>>   .../scsi/{scsi_debug.c => scsi_debug_main.c}  | 257 ++----------------
>>>   5 files changed, 308 insertions(+), 242 deletions(-)
>>
>> That's a pretty light commit message for so many modifications.
> 
> Hi John,
> 
> Thanks for having taken a look. The patch description is short because
> this patch doesn't do much: it 


> splits the scsi_debug source code in two
> files and modifies the Kconfig and Makefile. No functional changes are
> present in this patch.

I think that this info is useful.

About this:

On 29/02/2024 17:23, Bart Van Assche wrote:
 >   config SCSI_DEBUG
 >   	tristate "SCSI debugging host and device simulator"
 >   	depends on SCSI
 > -	select CRC_T10DIF
 > +	select CRC_T10DIF if SCSI_DEBUG = y

So this means that we select CRC_T10DIF if SCSI_DEBUG is only built-in, 
right?

Thanks,
John