From: Bart Van Assche <bvanassche@acm.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Daniel Mentz <danielmentz@google.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Stanley Jhu <chu.stanley@gmail.com>,
Avri Altman <avri.altman@wdc.com>,
Can Guo <quic_cang@quicinc.com>,
Asutosh Das <quic_asutoshd@quicinc.com>,
Bean Huo <beanhuo@micron.com>,
"Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
Arthur Simchaev <Arthur.Simchaev@wdc.com>
Subject: Re: [PATCH 2/2] scsi: ufs: Remove the ufshcd_hba_exit() call from ufshcd_async_scan()
Date: Wed, 20 Dec 2023 08:44:21 -0800 [thread overview]
Message-ID: <fd0b2b2e-c6f6-4b0e-a092-8ed79af1fb45@acm.org> (raw)
In-Reply-To: <20231220144813.GH3544@thinkpad>
On 12/20/23 06:48, Manivannan Sadhasivam wrote:
> On Mon, Dec 18, 2023 at 02:52:15PM -0800, Bart Van Assche wrote:
>> Calling ufshcd_hba_exit() from a function that is called asynchronously
>> from ufshcd_init() is wrong because this triggers multiple race
>> conditions. Instead of calling ufshcd_hba_exit(), log an error message.
>
> This also means that during failure, resources will not be powered OFF. IMO, a
> justification is needed why it is OK to left them powered ON.
I have never seen ufshcd_async_scan() fail other than during hardware bringup.
Has anyone else ever observed a ufshcd_async_scan() failure?
>> Reported-by: Daniel Mentz <danielmentz@google.com>
>> Fixes: 1d337ec2f35e ("ufs: improve init sequence")
>
> No need to backport this patch?
Isn't the "Fixes:" tag sufficient? I don't think that it it necessary to add a
"Cc: stable" tag if a "Fixes:" tag is present.
Thanks,
Bart.
next prev parent reply other threads:[~2023-12-20 16:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 22:52 [PATCH 0/2] Fix the error path in ufshcd_async_scan() Bart Van Assche
2023-12-18 22:52 ` [PATCH 1/2] scsi: ufs: Simplify power management during async scan Bart Van Assche
2023-12-19 5:04 ` Can Guo
2023-12-20 14:42 ` Manivannan Sadhasivam
2023-12-20 16:36 ` Bart Van Assche
2023-12-20 16:59 ` Manivannan Sadhasivam
2023-12-18 22:52 ` [PATCH 2/2] scsi: ufs: Remove the ufshcd_hba_exit() call from ufshcd_async_scan() Bart Van Assche
2023-12-19 5:05 ` Can Guo
2023-12-20 14:48 ` Manivannan Sadhasivam
2023-12-20 16:44 ` Bart Van Assche [this message]
2023-12-20 16:56 ` Manivannan Sadhasivam
2024-01-04 4:03 ` [PATCH 0/2] Fix the error path in ufshcd_async_scan() Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd0b2b2e-c6f6-4b0e-a092-8ed79af1fb45@acm.org \
--to=bvanassche@acm.org \
--cc=Arthur.Simchaev@wdc.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=chu.stanley@gmail.com \
--cc=danielmentz@google.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox