public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, jejb@linux.ibm.com,
	Finn Thain <fthain@telegraphics.com.au>
Subject: Re: [PATCH] scsi: scsi-lib.c: increase cmd_size by sizeof(struct scatterlist)
Date: Wed, 6 Nov 2019 20:21:48 +1300	[thread overview]
Message-ID: <fd48a151-ee0f-248c-22a3-abfffc2e1880@gmail.com> (raw)
In-Reply-To: <yq1h83h1rr6.fsf@oracle.com>

Thanks Martin,

Am 06.11.2019 um 18:46 schrieb Martin K. Petersen:
>
> Michael,
>
>> In scsi_mq_setup_tags(), cmd_size is calculated based on zero size
>> for the scatter-gather list in case the low level driver uses SG_NONE
>> in its host template.
>
> Applied to 5.4/scsi-fixes. I picked your version since it is small.

I realize it's more of a band-aid and doesn't address the real issue 
perhaps. Maybe it gives someone with a better clue about the block layer 
some idea though (I got out of my depth rather quickly).

> I still intend to queue Finn's SG_NONE cleanups for 5.5. In a way these
> are orthogonal.

Either zero or one work for sg_tablesize in my case, so that's perfectly 
fine by me.

Cheers,

	Michael

>
> Thanks!
>

  reply	other threads:[~2019-11-06  7:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02  1:06 [PATCH 0/2] SG_NONE fix and cleanup Finn Thain
2019-11-02  1:06 ` [PATCH 1/2] atari_scsi, sun3_scsi: Set sg_tablesize to 1 instead of SG_NONE Finn Thain
2019-11-02  1:06 ` [PATCH 2/2] scsi: Clean up SG_NONE Finn Thain
2019-11-05  2:49 ` [PATCH] scsi: scsi-lib.c: increase cmd_size by sizeof(struct scatterlist) Michael Schmitz
2019-11-05  5:54   ` Finn Thain
2019-11-06  5:46   ` Martin K. Petersen
2019-11-06  7:21     ` Michael Schmitz [this message]
2019-11-13  3:12 ` [PATCH 0/2] SG_NONE fix and cleanup Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd48a151-ee0f-248c-22a3-abfffc2e1880@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=fthain@telegraphics.com.au \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox