Re: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset()

[Marc Bejarano <beej@beej.org>]

René Bolldorf <xsecute <at> googlemail.com> writes:
> On 01/08/10 16:28, James Bottomley wrote:
> > On Thu, 2010-01-07 at 14:15 -0500, Jeff Garzik wrote:
> >> On 12/30/2009 05:59 PM, René Bolldorf wrote:
> >>> We don't need this .

> >>> - /* FIXME: is this needed? */
> >>> - memset(sense_buf, 0, SCSI_SENSE_BUFFERSIZE);
> >>
> >> I need a little bit more detail than an unqualified statement...  Did
> >> you audit all paths leading to this code point?

> > But one also here:
> >
> > 		u8 *sense_buffer = dev->link->ap->sector_buf;
> > 		[...]
> > 		err_mask = atapi_eh_request_sense(dev, sense_buffer, sense_key);
> >
> > Which doesn't look OK because it looks like the sector_buf isn't cleared
> > (and it is reused).
> >
> > James
> >
> >
> 
> Thank's, you're right. I have overseen this, sry for that.

René: perhaps you'd like to submit a patch that substitutes FIXME comment
for one that explains why the memset is needed, crediting James in the
description?  we may as well gain something permanent from this discussion
that you started :)

cheers,
marc

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html