Re: [PATCH 25/20] sysfs: Only support removing emtpy sysfs directories.

Alan Stern
2009-05-27T22:18:55Z

On Wed, 27 May 2009, Eric W. Biederman wrote:

> >> I think I have the fix to that...
> >
> > The fix is to delete the target when its children are deleted, and not
> > wait until the children are released.
>
> I think I can do both.
>
> I am currently working on a patchset which at the VFS layer disconnects a
> fd from an underlying device. It does the necessary use count tracking
> and when the disconnect is done it returns. As part of the disconnect it
> calls the release method.
>
> We already do this in at least sysfs, proc, sysctl, and sound. So I
> figure it is time to move this into some generic code so we don't need
> to duplicate the bugs and the insanities.
>
> Once merged it would take just a few lines of code to use this functionality.

That's good, but it isn't enough to solve this problem. Even though
user programs might not be able to pin the device by holding the file
open any more, other mechanisms (internal to the kernel) could have the
same effect. Only a short delay is needed.

The underlying cause should be fixed properly.

Alan Stern