Re: [PATCH] pci: enable MSI on 8132

Matthew Wilcox
2009-02-22T23:42:49Z

On Sun, Feb 22, 2009 at 04:54:54AM -0800, Eric W. Biederman wrote:
> + pci_write_config_dword(dev, pos + HT_MSI_ADDR_LO,
> + (HT_MSI_FIXED_ADDR & HT_MSI_FIXED_ADDR));

Presumably you meant "(HT_MSI_FIXED_ADDR & 0xffffffff)" here? Not that
it makes any difference, since it'll be implicitly truncated.

> + pci_write_config_dword(dev, pos + HT_MSI_ADDR_HI,
> + (HT_MSI_FIXED_ADDR >> 32));
> + }

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."