Re: [PATCH] pci: enable MSI on 8132

James Bottomley
2009-02-18T20:18:33Z

On Wed, 2009-02-18 at 15:12 -0500, Jeff Garzik wrote:
> James Bottomley wrote:
> > Like I said, I'm happy to have MSI completely disabled until LSI wants
> > to comment, so no ... only the PCI quirk fix. The true fix is to have
> > the drivers participate in dynamic testing of MSI IRQ routing, but I've
> > somewhat lost sight of that.
>
> That's not really a fix at all, just additional, unneeded overhead for
> 99% of users. We don't need our drivers bloated with self-check code
> for all the components in our various computer chips...

So you think the current per driver variably named parameter to turn off
MSI is better? Especially as most of the users who trip across a
platform having MSI problems don't even know that the storage failure is
caused by MSI, let alone how to find the parameter to fix the problem.

James