Re: growisofs stopped working with 2.6.8

Re: growisofs stopped working with 2.6.8

[Alan Cox]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

On Llu, 2004-08-16 at 17:38, Tony A. Lambley wrote:
> Hi, burning a dvd iso now fails :(
> 
> $ growisofs -Z /dev/hdc=file.iso
> :-( unable to GET CONFIGURATION: Operation not permitted
> :-( non-MMC unit?

We fixed some security holes. In doing so we tightened up so a few apps
that worked before no longer work except as root. Thanks for the error
message. Thats helpful as it suggests the following patch.

(and does it help K3B ?)






[-- Attachment #2: a1 --]
[-- Type: text/plain, Size: 379 bytes --]

--- drivers/block/scsi_ioctl.c~	2004-08-16 18:01:36.627301624 +0100
+++ drivers/block/scsi_ioctl.c	2004-08-16 18:01:36.627301624 +0100
@@ -146,6 +146,7 @@
 		safe_for_read(GPCMD_READ_TOC_PMA_ATIP),
 		safe_for_read(GPCMD_REPORT_KEY),
 		safe_for_read(GPCMD_SCAN),
+		safe_for_read(GPCMD_GET_CONFIGURATION),
 
 		/* Basic writing commands */
 		safe_for_write(WRITE_6),

Re: growisofs stopped working with 2.6.8

[Tony A. Lambley]

It still fails, but I get a different message with the patch:

$ growisofs -Z /dev/dvd=file.iso
Executing 'builtin_dd if=file.iso of=/dev/dvd obs=32k seek=0'
:-( unable to PREVENT MEDIA REMOVAL: Operation not permitted

K3B fails with the same message as above.

As you say, it does indeed burn fine as root.


On Mon, 2004-08-16 at 12:01, Alan Cox wrote:
> On Llu, 2004-08-16 at 17:38, Tony A. Lambley wrote:
> > Hi, burning a dvd iso now fails :(
> > 
> > $ growisofs -Z /dev/hdc=file.iso
> > :-( unable to GET CONFIGURATION: Operation not permitted
> > :-( non-MMC unit?
> 
> We fixed some security holes. In doing so we tightened up so a few apps
> that worked before no longer work except as root. Thanks for the error
> message. Thats helpful as it suggests the following patch.
> 
> (and does it help K3B ?)
> 
> 
> 
> 
> 
> 
> ______________________________________________________________________
> --- drivers/block/scsi_ioctl.c~	2004-08-16 18:01:36.627301624 +0100
> +++ drivers/block/scsi_ioctl.c	2004-08-16 18:01:36.627301624 +0100
> @@ -146,6 +146,7 @@
>  		safe_for_read(GPCMD_READ_TOC_PMA_ATIP),
>  		safe_for_read(GPCMD_REPORT_KEY),
>  		safe_for_read(GPCMD_SCAN),
> +		safe_for_read(GPCMD_GET_CONFIGURATION),
>  
>  		/* Basic writing commands */
>  		safe_for_write(WRITE_6),

Re: growisofs stopped working with 2.6.8

[Peter Osterlund]

"Tony A. Lambley" <tal@vextech.net> writes:

> It still fails, but I get a different message with the patch:
> 
> $ growisofs -Z /dev/dvd=file.iso
> Executing 'builtin_dd if=file.iso of=/dev/dvd obs=32k seek=0'
> :-( unable to PREVENT MEDIA REMOVAL: Operation not permitted
> 
> K3B fails with the same message as above.
> 
> As you say, it does indeed burn fine as root.

The patch below is needed for a start, but it's not enough, because
growisofs opens the device in read-only mode, so WRITE_10 fails
anyway.

--- drivers/block/scsi_ioctl.c~cdrw-filter	2004-08-16 17:13:23.000000000 +0200
+++ drivers/block/scsi_ioctl.c	2004-08-16 18:44:15.000000000 +0200
@@ -146,6 +146,13 @@
 		safe_for_read(GPCMD_READ_TOC_PMA_ATIP),
 		safe_for_read(GPCMD_REPORT_KEY),
 		safe_for_read(GPCMD_SCAN),
+		safe_for_read(GPCMD_GET_CONFIGURATION),
+		safe_for_read(GPCMD_READ_FORMAT_CAPACITIES),
+		safe_for_read(GPCMD_GET_EVENT_STATUS_NOTIFICATION),
+		safe_for_read(GPCMD_GET_PERFORMANCE),
+
+		safe_for_write(GPCMD_PREVENT_ALLOW_MEDIUM_REMOVAL),
+		safe_for_write(GPCMD_FLUSH_CACHE),
 
 		/* Basic writing commands */
 		safe_for_write(WRITE_6),

-- 
Peter Osterlund - petero2@telia.com
http://w1.894.telia.com/~u89404340