From: Andi Kleen <ak@muc.de>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [BK PATCH] essential SCSI fixes for 2.6.5-rc2
Date: Sat, 20 Mar 2004 13:33:57 +0100 [thread overview]
Message-ID: <m3u10jr93e.fsf@averell.firstfloor.org> (raw)
In-Reply-To: <1079793048.1778.6.camel@mulgrave> (James Bottomley's message of "20 Mar 2004 09:30:46 -0500")
James Bottomley <James.Bottomley@steeleye.com> writes:
> These are the two oops related fixes from the scsi-misc-2.6 tree that
> testing has shaken out. They are available at
>
> bk://linux-scsi.bkbits.net/scsi-for-linus-2.6
>
> The shortlog is:
>
[...]
Any chance you could include the fusion consistent mask patch with this?
Without this fusion is completely unusable with >4GB on 64bit.
-Andi
diff -burpN -X ../KDIFX -x '*-SLAB' linux-vanilla-2.6.5rc2/drivers/message/fusion/mptbase.c linux-2.6.5rc2-amd64/drivers/message/fusion/mptbase.c
--- linux-vanilla-2.6.5rc2/drivers/message/fusion/mptbase.c 2004-03-20 03:55:31.000000000 +0100
+++ linux-2.6.5rc2-amd64/drivers/message/fusion/mptbase.c 2004-03-20 04:11:24.000000000 +0100
@@ -1280,12 +1280,17 @@ mptbase_probe(struct pci_dev *pdev, cons
return r;
}
+#if 0
+ /* broken because some code assumes that multiple calls
+ to pci_alloc_consistent return data in the same 4GB segment.
+ This cannot work on machines with enough memory. */
if (!pci_set_consistent_dma_mask(pdev, mask))
dprintk((KERN_INFO MYNAM
": Using 64 bit consistent mask\n"));
else
dprintk((KERN_INFO MYNAM
": Not using 64 bit consistent mask\n"));
+#endif
ioc = kmalloc(sizeof(MPT_ADAPTER), GFP_ATOMIC);
if (ioc == NULL) {
next prev parent reply other threads:[~2004-03-20 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-20 14:30 [BK PATCH] essential SCSI fixes for 2.6.5-rc2 James Bottomley
2004-03-20 12:33 ` Andi Kleen [this message]
2004-03-20 15:21 ` James Bottomley
2004-03-21 5:26 ` Moore, Eric Dean
2004-03-21 4:36 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3u10jr93e.fsf@averell.firstfloor.org \
--to=ak@muc.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox