* found __[us]{8,16,32,64} type without #include <linux/types.h>
@ 2011-09-09 14:22 James Cloos
2011-09-09 14:29 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: James Cloos @ 2011-09-09 14:22 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-scsi, linux-mm, dri-devel
All noticed while compiling 3.1-r5:
linux/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux/usr/include/scsi/scsi_netlink.h:108: found __[us]{8,16,32,64} type without #include <linux/types.h>
linux/usr/include/linux/mmc/ioctl.h:10: found __[us]{8,16,32,64} type without #include <linux/types.h>
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: found __[us]{8,16,32,64} type without #include <linux/types.h>
2011-09-09 14:22 found __[us]{8,16,32,64} type without #include <linux/types.h> James Cloos
@ 2011-09-09 14:29 ` Arnd Bergmann
2011-09-12 15:27 ` James Cloos
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2011-09-09 14:29 UTC (permalink / raw)
To: James Cloos; +Cc: linux-kernel, linux-scsi, linux-mm, dri-devel
On Friday 09 September 2011, James Cloos wrote:
> All noticed while compiling 3.1-r5:
>
> linux/usr/include/drm/drm_mode.h:85: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux/usr/include/drm/i915_drm.h:120: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux/usr/include/drm/mga_drm.h:260: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux/usr/include/drm/radeon_drm.h:758: found __[us]{8,16,32,64} type without #include <linux/types.h>
> linux/usr/include/drm/via_drm.h:117: found __[us]{8,16,32,64} type without #include <linux/types.h>
This has been around for a long time, I think. I agree that we should do
something about it, but I think we're still looking for a solution that
makes everyone happy.
The script only checks for direct inclusions of types.h, while the drm headers
get it from drm.h. One solution would be to make the script smart enough
to evaluate all indirect header inclusions as well. A more hacky workaround
would be to just treat "drm.h" the same as <linux/types.h>.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: found __[us]{8,16,32,64} type without #include <linux/types.h>
2011-09-09 14:29 ` Arnd Bergmann
@ 2011-09-12 15:27 ` James Cloos
0 siblings, 0 replies; 3+ messages in thread
From: James Cloos @ 2011-09-12 15:27 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: dri-devel, linux-kernel, linux-scsi
>>>>> "AB" == Arnd Bergmann <arnd@arndb.de> writes:
AB> The script only checks for direct inclusions of types.h, while the
AB> drm headers get it from drm.h.
I see. It had been quite some time since I last did a make 1>/dev/null,
long enough that I hadn't noticed that message before.
It is good to know that it is a false positive.
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-12 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-09 14:22 found __[us]{8,16,32,64} type without #include <linux/types.h> James Cloos
2011-09-09 14:29 ` Arnd Bergmann
2011-09-12 15:27 ` James Cloos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox