From: Johannes Thumshirn <jthumshirn@suse.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org,
Konstantin Khorenko <khorenko@virtuozzo.com>,
Stuart Hayes <stuart.w.hayes@gmail.com>,
Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] Ensure that the SCSI error handler gets woken up
Date: Fri, 01 Dec 2017 09:45:47 +0100 [thread overview]
Message-ID: <mqd609q4z0k.fsf@linux-x5ow.site> (raw)
In-Reply-To: <20171130224456.23100-2-bart.vanassche@wdc.com> (Bart Van Assche's message of "Thu, 30 Nov 2017 14:44:55 -0800")
Hi Bart,
Bart Van Assche <bart.vanassche@wdc.com> writes:
[...]
> + if (shost_state != shost->shost_state) {
> + spin_unlock_irqrestore(shost->host_lock, flags);
> + synchronize_rcu();
> + spin_lock_irqsave(shost->host_lock, flags);
> + }
Plese correct me if I'm wrong, but once you drop the host lock all
assumptions about states it protects are void, aren't they?
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-12-01 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 22:44 [PATCH 0/2] Ensure that the SCSI error handler gets woken up Bart Van Assche
2017-11-30 22:44 ` [PATCH 1/2] " Bart Van Assche
2017-12-01 8:42 ` Pavel Tikhomirov
2017-12-01 17:42 ` Bart Van Assche
2017-12-01 8:45 ` Johannes Thumshirn [this message]
2017-12-01 17:40 ` Bart Van Assche
2017-11-30 22:44 ` [PATCH 2/2] Convert a source code comment into a runtime check Bart Van Assche
2017-12-01 8:46 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mqd609q4z0k.fsf@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=khorenko@virtuozzo.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ptikhomirov@virtuozzo.com \
--cc=stable@vger.kernel.org \
--cc=stuart.w.hayes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).