Re: [PATCH] ibmvscsi driver - third version

Christoph Hellwig
2004-02-25T13:45:22Z

On Mon, Feb 23, 2004 at 11:34:17PM -0600, Dave Boutcher wrote:
> This is the third version of the SCSI driver to support the adapter
> implemented by the IBM Power5 firmware. I have incorporated all comments
> from the previous submissions. Probably the most significant functional
> change is that all locking is done with the host_lock now.

This one still has the issue with error returns from queuecommand.

Here are the rules for queuecommand again:

- either your return 0, then you must finish the command through it's
->done callback
- or you return SCSI_MLQUEUE_HOST_BUSY/SCSI_MLQUEUE_DEVICE_BUSY and must
_not_ call ->done.

There's also a fair share of style issues left. What about simply running
it through scripts/Lindent?