From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: linux-block@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue_ready()
Date: Mon, 4 Dec 2017 23:48:07 +0000 (UTC) [thread overview]
Message-ID: <pan$2c3c7$7c7c04a5$f22df3ad$bef841cb@applied-asynchrony.com> (raw)
In-Reply-To: 20171204224507.GB6888@ming.t460p
On Tue, 05 Dec 2017 06:45:08 +0800, Ming Lei wrote:
> On Mon, Dec 04, 2017 at 03:09:20PM +0000, Bart Van Assche wrote:
>> On Sun, 2017-12-03 at 00:31 +0800, Ming Lei wrote:
>> > Fixes: 0df21c86bdbf ("scsi: implement .get_budget and .put_budget for blk-mq")
>>
>> It might be safer to revert commit 0df21c86bdbf instead of trying to fix all
>> issues introduced by that commit for kernel version v4.15 ...
>
> What are all issues in v4.15-rc? Up to now, it is the only issue reported,
> and can be fixed by this simple patch, which one can be thought as cleanup
> too.
Even with this patch I've encountered at least one hang that
seemed related. I'm using most of block/scsi-4.15 on top of 4.14 and
the hang in question was on a rotating disk. It could be solved by activating
a different scheduler on the hanging device; all hanging sync/df processes got
unstuck and all was fine again, which leads me to believe that there is at least
one more rare condition where delaying requests (as done in the budget patch)
leads to a hang.
This happened with mq-deadline which I was testing specifically to avoid
any BFQ-related side effects.
I didn't do anything specific to trigger the hang and have not been able
to reproduce it during regular usage.
-h
next prev parent reply other threads:[~2017-12-04 23:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 16:31 [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue_ready() Ming Lei
2017-12-04 8:19 ` Johannes Thumshirn
2017-12-04 8:34 ` Ming Lei
2017-12-04 8:44 ` Johannes Thumshirn
2017-12-04 8:58 ` Ming Lei
2017-12-04 15:09 ` Bart Van Assche
2017-12-04 22:45 ` Ming Lei
2017-12-04 22:49 ` Bart Van Assche
2017-12-04 23:48 ` Holger Hoffstätte [this message]
2017-12-05 5:16 ` Ming Lei
2017-12-05 6:56 ` Ming Lei
2017-12-05 11:26 ` Holger Hoffstätte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='pan$2c3c7$7c7c04a5$f22df3ad$bef841cb@applied-asynchrony.com' \
--to=holger@applied-asynchrony.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox