Re: [PATCH v8 02/12] ufs: unipro: Move Tx/Rx FSM state definitions to unipro.h

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ufs: namespace pollution with generic enum constants in unipro.h
--

commit ebc07859adf01890c26a7b7401dc6900f6ce9105
Author: Larisa Grigore <larisa.grigore@oss.nxp.com>

ufs: unipro: Move Tx/Rx FSM state definitions to unipro.h

This patch moves the Tx/Rx FSM state definitions from a driver-private
header into the subsystem-shared <ufs/unipro.h> header. It also drops
driver-specific definitions and updates checks to use the shared enum
constants.

> diff --git a/include/ufs/unipro.h b/include/ufs/unipro.h
> index 9c168703b1048..e0f490e11c7f7 100644
> --- a/include/ufs/unipro.h
> +++ b/include/ufs/unipro.h
> @@ -466,4 +466,24 @@ enum {
>  	CPORT_CONNECTED,
>  };
>  
> +/* RX_FSM_State encoding, MIPI M-PHY v6.0 Table 50 (M-RX Status Attributes) */
> +enum ufs_rx_fsm_state {
> +	RX_STATE_DISABLED = 0,

[Severity: Low]
Since these highly generic enum constants are now globally visible to any
file including <ufs/unipro.h>, could this cause namespace pollution and
build conflicts with other subsystems?

Would it be better to prefix the constant values with UFS_ or MPHY_
(for example, UFS_RX_STATE_DISABLED)?

> +	RX_STATE_HIBERN8 = 1,
> +	RX_STATE_SLEEP = 2,
> +	RX_STATE_STALL = 3,
> +	RX_STATE_LSBURST = 4,
> +	RX_STATE_HSBURST = 5,
> +};
> +
> +/* TX_FSM_State encoding, MIPI M-PHY v6.0 Table 47 (M-TX Status Attributes) */
> +enum ufs_tx_fsm_state {
> +	TX_STATE_DISABLED = 0,
> +	TX_STATE_HIBERN8 = 1,
> +	TX_STATE_SLEEP = 2,
> +	TX_STATE_STALL = 3,
> +	TX_STATE_LSBURST = 4,
> +	TX_STATE_HSBURST = 5,
> +};
> +
>  #endif /* _UNIPRO_H_ */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013103003.373156-1-larisa.grigore@oss.nxp.com?part=2