Re: [PATCH v4] scsi: ufs: Change the error check sequence for auto hibern8

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] scsi: ufs: unmatched opening brace in ufshcd_uic_cmd_compl()
--

commit 0662e042cc8b3241cb51d99b2a23b42e34c3390e
Author: HOYOUNG SEO <hy50.seo@samsung.com>

scsi: ufs: Change the error check sequence for auto hibern8

This commit moves the auto-hibern8 error check in ufshcd_uic_cmd_compl()
ahead of the active UIC command NULL check so that auto-hibern8 errors are
recorded in hba->errors even when no UIC command is active. It also avoids
logging an error for a missing UIC command when an auto-hibern8 error is
detected.

> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index cc75384c65021..1dd9fbf2e696c 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -5928,16 +5928,22 @@ static irqreturn_t ufshcd_uic_cmd_compl(struct ufs_hba *hba, u32 intr_status)
>  	struct uic_command *cmd;
>  
>  	guard(spinlock_irqsave)(&hba->host->host_lock);
> +
> +	/*
> +	 * Auto-hibern8 is performed without a UIC command, so check for
> +	 * auto-hibern8 errors before checking for an active UIC command.
> +	 */
> +	if (ufshcd_is_auto_hibern8_error(hba, intr_status)) {
> +		hba->errors |= (UFSHCD_UIC_HIBERN8_MASK & intr_status);
> +
>  	cmd = hba->active_uic_cmd;

[Severity: High]
In ufshcd_uic_cmd_compl() in drivers/ufs/core/ufshcd.c, the
if (ufshcd_is_auto_hibern8_error(hba, intr_status)) statement opens a brace
without a matching closing brace before cmd = hba->active_uic_cmd.

Because the block is never closed, the remainder of ufshcd_uic_cmd_compl() is
enclosed inside the conditional and the final brace of ufshcd_uic_cmd_compl()
closes the if statement rather than the function body, breaking compilation
when building drivers/ufs/core/ufshcd.c.

Should the opening brace on the if statement be removed (or closed with a
matching brace)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261026052632.1848929-1-hy50.seo@samsung.com?part=1