Re: [PATCH] scsi: qedi: Add __printf to debug helpers and fix format strings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] scsi: qedi: -Wformat build error in
  qedi_alloc_nvm_iscsi_cfg() on 32-bit DMA
--

commit dbd61cf20f660a9013f24529bb4ce72d39dfb22d
Author: Adrián García Casado <adriangarciacasado42@gmail.com>

scsi: qedi: Add __printf to debug helpers and fix format strings

This commit adds __printf() attributes to the qedi_dbg_*() logging helpers
and updates format strings in qedi_fw.c and qedi_main.c to match their
argument types.

> diff --git a/drivers/scsi/qedi/qedi_dbg.h b/drivers/scsi/qedi/qedi_dbg.h
> index 8649518658691..70acb55847f4f 100644
> --- a/drivers/scsi/qedi/qedi_dbg.h
> +++ b/drivers/scsi/qedi/qedi_dbg.h
> @@ -78,12 +78,16 @@ struct qedi_dbg_ctx {
>  		qedi_dbg_info(pdev, __func__, __LINE__, level, fmt,	\
>  			      ## __VA_ARGS__)
>  
> +__printf(4, 5)
>  void qedi_dbg_err(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
>  		  const char *fmt, ...);
> +__printf(4, 5)
>  void qedi_dbg_warn(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
>  		   const char *fmt, ...);
> +__printf(4, 5)
>  void qedi_dbg_notice(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
>  		     const char *fmt, ...);
> +__printf(5, 6)
>  void qedi_dbg_info(struct qedi_dbg_ctx *qedi, const char *func, u32 line,
>  		   u32 info, const char *fmt, ...);

[Severity: Medium]
Does adding __printf(5, 6) to qedi_dbg_info() cause a -Wformat build
regression in qedi_alloc_nvm_iscsi_cfg() when CONFIG_ARCH_DMA_ADDR_T_64BIT
is not set?

drivers/scsi/qedi/qedi_main.c:qedi_alloc_nvm_iscsi_cfg() {
	...
	QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_INFO,
		  "NVM BUF addr=0x%p dma=0x%llx.\n", qedi->iscsi_image,
		  qedi->nvm_buf_dma);
	...
}

qedi->nvm_buf_dma is a dma_addr_t, which is u32 on 32-bit DMA
configurations, so formatting it with 0x%llx instead of %pad (passing
&qedi->nvm_buf_dma) triggers a format warning and breaks CONFIG_WERROR=y
builds.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109141738.1624579-1-adriangarciacasado42@gmail.com?part=1