From: jackysliu <1972843537@qq.com>
To: lkp@intel.com
Cc: 1972843537@qq.com, GR-QLogic-Storage-Upstream@marvell.com,
James.Bottomley@hansenpartnership.com, jhasan@marvell.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, oe-kbuild-all@lists.linux.dev,
skashyap@marvell.com
Subject: [PATCH] scsi: qedf: fix inconsistent indenting warning
Date: Tue, 24 Jun 2025 11:19:19 +0800 [thread overview]
Message-ID: <tencent_DB9950A0D2FA71F96EE7FDDF92F6DE959A09@qq.com> (raw)
In-Reply-To: <202506240340.fv6cXpyc-lkp@intel.com>
Fix below inconsistent indenting smatch warning.
New smatch warnings:
drivers/scsi/qedf/qedf_main.c:2814 qedf_prepare_sb() warn: inconsistent
indenting
Old smatch warnings:
drivers/scsi/qedf/qedf_main.c:2816 qedf_prepare_sb() warn: inconsistent indenting
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202506240340.fv6cXpyc-lkp@intel.com/
Signed-off-by: jackysliu <1972843537@qq.com>
---
drivers/scsi/qedf/qedf_main.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index 8767d9de819f..b46fc510557b 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2810,11 +2810,11 @@ static int qedf_prepare_sb(struct qedf_ctx *qedf)
}
err:
for (int i = 0; i < id; i++) {
-fp = &qedf->fp_array[i];
-if (fp->sb_info) {
-qedf_free_sb(qedf, fp->sb_info);
-kfree(fp->sb_info);
-fp->sb_info = NULL;
+ fp = &qedf->fp_array[i];
+ if (fp->sb_info) {
+ qedf_free_sb(qedf, fp->sb_info);
+ kfree(fp->sb_info);
+ fp->sb_info = NULL;
}
}
kfree(qedf->fp_array);
--
2.43.5
prev parent reply other threads:[~2025-06-24 3:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-17 9:55 [PATCH] scsi: qedf: Fix a possible memory leak in qedf_prepare_sb() jackysliu
2025-06-23 19:36 ` kernel test robot
2025-06-24 3:16 ` [PATCH] [PATCH] scsi: qedf: fix inconsistent indenting warning Fix below inconsistent indenting smatch warning. New smatch warnings: drivers/scsi/qedf/qedf_main.c:2814 qedf_prepare_sb() warn: inconsistent indenting jackysliu
2025-06-24 3:19 ` jackysliu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_DB9950A0D2FA71F96EE7FDDF92F6DE959A09@qq.com \
--to=1972843537@qq.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jhasan@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.petersen@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=skashyap@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox