Re: [stable] [PATCH 1/2] sd: fix memory corruption by sd_read_cache_type

Al Viro
2006-02-26T08:22:22Z

On Sun, Feb 26, 2006 at 09:11:08AM +0100, Stefan Richter wrote:
> Al Viro wrote:
> >Speaking of sbp2 problems... Why the _hell_ are we blacklisting on
> >firmware revision alone? Especially with entries like "all firmware
> >with 2.<whatever> as version is broken"...
>
> The firmware_revision CSR key value has so far been a good method to
> guesstimate the bridge chip. I don't know a better one.

Umm... What about ->vendor_name_kv (plus firmware_revision, obviously)?

> I posted an improved blacklisting patch a few days ago. Among other
> small cleanups, I removed skip_ms_page_8 from the Initio blacklist entry.
> http://marc.theaimsgroup.com/?l=linux1394-devel&m=114065678722190

FWIW, that puppy appears to live just fine without forcing 36byte
inquiry here...