Re: [stable] [PATCH 1/2] sd: fix memory corruption by sd_read_cache_type

Stefan Richter
2006-02-26T08:12:46Z

Al Viro wrote:
> Speaking of sbp2 problems... Why the _hell_ are we blacklisting on
> firmware revision alone? Especially with entries like "all firmware
> with 2.<whatever> as version is broken"...

The firmware_revision CSR key value has so far been a good method to
guesstimate the bridge chip. I don't know a better one.

> Case in point: Initio bridge, firmware revision 2.21. Couldn't care
> less about long INQUIRY, doesn't need skip_ms_page_8, *DOES* need
> correctly detected cache type.
...

I agree.

I posted an improved blacklisting patch a few days ago. Among other
small cleanups, I removed skip_ms_page_8 from the Initio blacklist entry.
http://marc.theaimsgroup.com/?l=linux1394-devel&m=114065678722190
--
Stefan Richter
-=====-=-==- --=- ==-=-