From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: linux-scsi@vger.kernel.org
Subject: On patch "Let scsi_cmnd->cmnd use request->cmd buffer"
Date: Sun, 4 May 2008 01:30:27 +0200 (CEST) [thread overview]
Message-ID: <tkrat.5db1d90bfe8d480e@s5r6.in-berlin.de> (raw)
Commit 64a87b244b9297667ca80264aab849a36f494884 contains:
-------------------------- drivers/firewire/fw-sbp2.c --------------------------
index 2a99937..dda82f3 100644
@@ -1487,7 +1487,7 @@ static int sbp2_scsi_queuecommand(struct scsi_cmnd *cmd, scsi_done_fn_t done)
if (scsi_sg_count(cmd) && sbp2_map_scatterlist(orb, device, lu) < 0)
goto out;
- memcpy(orb->request.command_block, cmd->cmnd, COMMAND_SIZE(*cmd->cmnd));
+ memcpy(orb->request.command_block, cmd->cmnd, cmd->cmd_len);
orb->base.callback = complete_command_orb;
orb->base.request_bus =
Should drivers/ieee1394/sbp2.c::sbp2_create_command_orb() be changed in
the same way?
--
Stefan Richter
-=====-==--- -=-= --=--
http://arcgraph.de/sr/
next reply other threads:[~2008-05-03 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 23:30 Stefan Richter [this message]
2008-05-04 12:15 ` On patch "Let scsi_cmnd->cmnd use request->cmd buffer" Boaz Harrosh
2008-05-04 12:44 ` Stefan Richter
2008-05-04 13:01 ` Stefan Richter
2008-05-04 13:36 ` Boaz Harrosh
2008-05-04 13:46 ` Boaz Harrosh
2008-05-04 14:50 ` Stefan Richter
2008-05-04 14:54 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.5db1d90bfe8d480e@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox