From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux-scsi@vger.kernel.org
Cc: Douglas Gilbert <dougg@torque.net>,
Joern Quillman <quillman@fbihome.de>,
Brian King <brking@us.ibm.com>,
James Bottomley <James.Bottomley@SteelEye.com>
Subject: [PATCH] scsi: sd: configurable allow_restart attribute for all device types
Date: Tue, 21 Nov 2006 21:34:08 +0100 (CET) [thread overview]
Message-ID: <tkrat.b0153a503f02a550@s5r6.in-berlin.de> (raw)
In-Reply-To: <45631017.4080601@us.ibm.com>
It is not necessary to restrict run-time configuration of sd's
allow_restart attribute to SBC disks.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Index: linux-2.6.19-rc6/drivers/scsi/sd.c
===================================================================
--- linux-2.6.19-rc6.orig/drivers/scsi/sd.c 2006-10-10 18:18:45.000000000 +0200
+++ linux-2.6.19-rc6/drivers/scsi/sd.c 2006-11-21 21:15:10.000000000 +0100
@@ -216,9 +216,6 @@ static ssize_t sd_store_allow_restart(st
if (!capable(CAP_SYS_ADMIN))
return -EACCES;
- if (sdp->type != TYPE_DISK)
- return -EINVAL;
-
sdp->allow_restart = simple_strtoul(buf, NULL, 10);
return count;
next prev parent reply other threads:[~2006-11-21 20:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 17:38 Spinup of SCSI Disks: allow_restart won't work on 2.6.18 Joern Quillman
2006-11-17 21:44 ` Joern Quillmann
2006-11-17 23:34 ` Stefan Richter
2006-11-17 23:36 ` Stefan Richter
2006-11-20 10:52 ` Joern Quillman
2006-11-20 11:48 ` Stefan Richter
2006-11-20 22:32 ` Joern Quillman
2006-11-20 23:53 ` Stefan Richter
2006-11-21 0:54 ` Douglas Gilbert
2006-11-21 4:20 ` James Bottomley
2006-11-21 8:12 ` Stefan Richter
2006-11-21 14:41 ` Brian King
2006-11-21 20:34 ` Stefan Richter [this message]
2006-11-21 1:09 ` Joern Quillmann
2006-11-21 20:49 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.b0153a503f02a550@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=James.Bottomley@SteelEye.com \
--cc=brking@us.ibm.com \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
--cc=quillman@fbihome.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox