From: Jeff Moyer <jmoyer@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [patch,v3,repost 00/10] make I/O path allocations more numa-friendly
Date: Fri, 14 Dec 2012 11:05:04 -0500 [thread overview]
Message-ID: <x49pq2czkjz.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <1355220811.2400.5.camel@dabdike.int.hansenpartnership.com> (James Bottomley's message of "Tue, 11 Dec 2012 10:13:31 +0000")
James Bottomley <James.Bottomley@HansenPartnership.com> writes:
> On Mon, 2012-12-10 at 12:59 -0500, Jeff Moyer wrote:
>> Jeff Moyer <jmoyer@redhat.com> writes:
>>
>> > Hi,
>> >
>> > This patch set makes memory allocations for data structures used in
>> > the I/O path more numa friendly by allocating them from the same numa
>> > node as the storage device. I've only converted a handful of drivers
>> > at this point. My testing is limited by the hardware I have on hand.
>> > Using these patches, I was able to max out the bandwidth of the storage
>> > controller when issuing I/O from any node on my 4 node system. Without
>> > the patch, I/O from nodes remote to the storage device would suffer a
>> > penalty ranging from 6-12%. Given my relatively low-end setup[1], I
>> > wouldn't be surprised if others could show a more significant performance
>> > advantage.
>> >
>> > This is a repost of the last posting. The only changes are additional
>> > reviewed-by/acked-by tags. I think this version is ready for inclusion.
>> > James, would you mind taking a look?
>>
>> James? Do you have any objections to including this for 3.8?
>
> Probably for 3.9 since the 3.8 merge window is upon us.
OK.
> Do we actually have any performance numbers from the big system people?
> That's really a must for this type of work.
I'm working on getting some numbers.
> It's missing acks from the affected drivers; that's not a show stopper
> but it would be better to have them.
Well, we could trim the driver list to those that have ACKs, but the
driver changes are trivial.
Thanks,
Jeff
prev parent reply other threads:[~2012-12-14 16:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 16:46 [patch,v3,repost 00/10] make I/O path allocations more numa-friendly Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 01/10] scsi: add scsi_host_alloc_node Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 02/10] scsi: make __scsi_alloc_queue numa-aware Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 03/10] scsi: make scsi_alloc_sdev numa-aware Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 05/10] sd: use alloc_disk_node Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 06/10] ata: use scsi_host_alloc_node Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 07/10] megaraid_sas: " Jeff Moyer
2012-12-04 1:41 ` adam radford
2012-11-27 16:46 ` [patch,v3,repost 08/10] mpt2sas: " Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 09/10] lpfc: " Jeff Moyer
2012-11-27 16:46 ` [patch,v3,repost 10/10] cciss: use blk_init_queue_node Jeff Moyer
2012-12-10 17:59 ` [patch,v3,repost 00/10] make I/O path allocations more numa-friendly Jeff Moyer
2012-12-11 10:13 ` James Bottomley
2012-12-14 16:05 ` Jeff Moyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49pq2czkjz.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).