From: Jeff Moyer <jmoyer@redhat.com>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: [patch/rfc/rft] sd: allocate request_queue on device's local numa node
Date: Mon, 22 Oct 2012 15:01:42 -0400 [thread overview]
Message-ID: <x49pq4axre1.fsf@segfault.boston.devel.redhat.com> (raw)
Hi,
All of the infrastructure is available to allocate a request_queue on a
particular numa node, but it isn't being utilized at all. Wire up the
sd driver to allocate the request_queue on the HBA's local numa node.
This is a request for comments and testing (I've built and booted it,
nothing more). I believe that this should be a performance win, but I
have no numbers to back it up as yet. Suggestions for workloads to test
are welcome.
Cheers,
Jeff
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index da36a3a..7986483 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1664,7 +1664,8 @@ struct request_queue *__scsi_alloc_queue(struct Scsi_Host *shost,
struct request_queue *q;
struct device *dev = shost->dma_dev;
- q = blk_init_queue(request_fn, NULL);
+ q = blk_init_queue_node(request_fn, NULL,
+ dev_to_node(&shost->shost_dev));
if (!q)
return NULL;
next reply other threads:[~2012-10-22 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 19:01 Jeff Moyer [this message]
2012-10-22 19:19 ` [patch/rfc/rft] sd: allocate request_queue on device's local numa node Jens Axboe
2012-10-23 6:45 ` Bart Van Assche
2012-10-23 16:52 ` Jeff Moyer
2012-10-23 17:42 ` Bart Van Assche
2012-10-23 17:58 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49pq4axre1.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).