From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Benjamin LaHaise <bcrl@kvack.org>,
"Elliott, Robert (Server Storage)" <Elliott@hp.com>,
Christoph Hellwig <hch@infradead.org>,
"dgilbert@interlog.com" <dgilbert@interlog.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Bart Van Assche <bvanassche@fusionio.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: scsi-mq V2
Date: Thu, 10 Jul 2014 16:05:02 -0400 [thread overview]
Message-ID: <x49r41tyo7l.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <53BEF0A8.7010608@kernel.dk> (Jens Axboe's message of "Thu, 10 Jul 2014 21:59:36 +0200")
Jens Axboe <axboe@kernel.dk> writes:
> On 2014-07-10 17:11, Jeff Moyer wrote:
>> Benjamin LaHaise <bcrl@kvack.org> writes:
>>
>>>>
>>>> [ 186.339064] ioctx_alloc: nr_events=-2 aio_max_nr=65536
>>>> [ 186.339065] ioctx_alloc: nr_events=-2 aio_max_nr=65536
>>>> [ 186.339067] ioctx_alloc: nr_events=-2 aio_max_nr=65536
>>>> [ 186.339068] ioctx_alloc: nr_events=-2 aio_max_nr=65536
>>>> [ 186.339069] ioctx_alloc: nr_events=-2 aio_max_nr=65536
>>>
>>> Something is horribly wrong here. There is no way that value for nr_events
>>> should be passed in to ioctx_alloc(). This implies that userland is calling
>>> io_setup() with an impossibly large value for nr_events. Can you post the
>>> actual diff for your fs/aio.c relative to linus' tree?
>>>
>>
>> fio does exactly this! it passes INT_MAX.
>
> That's correct, I had actually forgotten about this. It was a change
> made a few years back, in correlation with the aio optimizations
> posted then, basically telling aio to ignore that silly (and broken)
> user ring.
I still don't see how you accomplish that. Making it bigger doesn't get
rid of it. ;-)
Cheers,
Jeff
next prev parent reply other threads:[~2014-07-10 20:05 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 16:51 scsi-mq V2 Christoph Hellwig
2014-06-25 16:51 ` [PATCH 01/14] sd: don't use rq->cmd_len before setting it up Christoph Hellwig
2014-07-09 11:12 ` Hannes Reinecke
2014-07-09 15:03 ` Christoph Hellwig
2014-06-25 16:51 ` [PATCH 02/14] scsi: split __scsi_queue_insert Christoph Hellwig
2014-07-09 11:12 ` Hannes Reinecke
2014-06-25 16:51 ` [PATCH 03/14] scsi: centralize command re-queueing in scsi_dispatch_fn Christoph Hellwig
2014-07-08 20:51 ` Elliott, Robert (Server Storage)
2014-07-09 6:40 ` Christoph Hellwig
2014-07-09 11:13 ` Hannes Reinecke
2014-06-25 16:51 ` [PATCH 04/14] scsi: set ->scsi_done before calling scsi_dispatch_cmd Christoph Hellwig
2014-07-09 11:14 ` Hannes Reinecke
2014-06-25 16:51 ` [PATCH 05/14] scsi: push host_lock down into scsi_{host,target}_queue_ready Christoph Hellwig
2014-07-09 11:14 ` Hannes Reinecke
2014-06-25 16:51 ` [PATCH 06/14] scsi: convert target_busy to an atomic_t Christoph Hellwig
2014-07-09 11:15 ` Hannes Reinecke
2014-06-25 16:51 ` [PATCH 07/14] scsi: convert host_busy to atomic_t Christoph Hellwig
2014-07-09 11:15 ` Hannes Reinecke
2014-06-25 16:51 ` [PATCH 08/14] scsi: convert device_busy " Christoph Hellwig
2014-07-09 11:16 ` Hannes Reinecke
2014-07-09 16:49 ` James Bottomley
2014-07-10 6:01 ` Christoph Hellwig
2014-06-25 16:51 ` [PATCH 09/14] scsi: fix the {host,target,device}_blocked counter mess Christoph Hellwig
2014-07-09 11:12 ` Hannes Reinecke
2014-07-10 6:06 ` Christoph Hellwig
2014-06-25 16:51 ` [PATCH 10/14] scsi: only maintain target_blocked if the driver has a target queue limit Christoph Hellwig
2014-07-09 11:19 ` Hannes Reinecke
2014-07-09 15:05 ` Christoph Hellwig
2014-06-25 16:51 ` [PATCH 11/14] scsi: unwind blk_end_request_all and blk_end_request_err calls Christoph Hellwig
2014-07-09 11:20 ` Hannes Reinecke
2014-06-25 16:51 ` [PATCH 12/14] scatterlist: allow chaining to preallocated chunks Christoph Hellwig
2014-07-09 11:21 ` Hannes Reinecke
2014-06-25 16:52 ` [PATCH 13/14] scsi: add support for a blk-mq based I/O path Christoph Hellwig
2014-07-09 11:25 ` Hannes Reinecke
2014-07-16 11:13 ` Mike Christie
2014-07-16 11:16 ` Christoph Hellwig
2014-06-25 16:52 ` [PATCH 14/14] fnic: reject device resets without assigned tags for the blk-mq case Christoph Hellwig
2014-07-09 11:27 ` Hannes Reinecke
2014-06-26 4:50 ` scsi-mq V2 Jens Axboe
2014-06-26 22:07 ` Elliott, Robert (Server Storage)
2014-06-27 14:42 ` Bart Van Assche
2014-06-30 15:20 ` Jens Axboe
2014-06-30 15:25 ` Christoph Hellwig
2014-06-30 15:54 ` Martin K. Petersen
2014-07-08 14:48 ` Christoph Hellwig
2014-07-09 16:39 ` Douglas Gilbert
2014-07-09 19:38 ` Jens Axboe
2014-07-10 0:53 ` Elliott, Robert (Server Storage)
2014-07-10 6:20 ` Christoph Hellwig
2014-07-10 13:36 ` Benjamin LaHaise
2014-07-10 13:39 ` Jens Axboe
2014-07-10 13:44 ` Benjamin LaHaise
2014-07-10 13:48 ` Jens Axboe
2014-07-10 13:50 ` Benjamin LaHaise
2014-07-10 13:52 ` Jens Axboe
2014-07-10 13:50 ` Christoph Hellwig
2014-07-10 13:52 ` Jens Axboe
2014-07-10 14:36 ` Elliott, Robert (Server Storage)
2014-07-10 14:45 ` Benjamin LaHaise
2014-07-10 15:11 ` Jeff Moyer
2014-07-10 19:59 ` Jens Axboe
2014-07-10 20:05 ` Jeff Moyer [this message]
2014-07-10 20:06 ` Jens Axboe
2014-07-10 15:51 ` Elliott, Robert (Server Storage)
2014-07-10 16:04 ` Christoph Hellwig
2014-07-10 16:14 ` Christoph Hellwig
2014-07-10 18:49 ` Elliott, Robert (Server Storage)
2014-07-10 19:14 ` Jeff Moyer
2014-07-10 19:36 ` Jeff Moyer
2014-07-10 21:10 ` Elliott, Robert (Server Storage)
2014-07-11 6:02 ` Elliott, Robert (Server Storage)
2014-07-11 6:14 ` Christoph Hellwig
2014-07-11 14:33 ` Elliott, Robert (Server Storage)
2014-07-11 14:55 ` Benjamin LaHaise
2014-07-12 21:50 ` Elliott, Robert (Server Storage)
2014-07-12 23:20 ` Elliott, Robert (Server Storage)
2014-07-13 17:15 ` Elliott, Robert (Server Storage)
2014-07-14 17:15 ` Benjamin LaHaise
2014-07-14 9:13 ` Sagi Grimberg
2014-08-21 12:32 ` Performance degradation in IO writes vs. reads (was scsi-mq V2) Sagi Grimberg
2014-08-21 13:03 ` Christoph Hellwig
2014-08-21 14:02 ` Sagi Grimberg
2014-08-24 16:41 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49r41tyo7l.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=Elliott@hp.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=bvanassche@fusionio.com \
--cc=dgilbert@interlog.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).