Re: [patch 10/11] drivers/scsi/: Use the DMA_{64,32}BIT_MASK constants

[Jes Sorensen <jes@wildopensource.com>]

>>>>> "Matthew" == Matthew Wilcox <matthew@wil.cx> writes:

Matthew> On Mon, Mar 07, 2005 at 05:14:16AM -0500, Jes Sorensen wrote:
>> >>>>> "domen" == domen <domen@coderock.org> writes:
>> 
domen> Use the DMA_{64,32}BIT_MASK constants from dma-mapping.h when
domen> calling pci_set_dma_mask() or pci_set_consistent_dma_mask() See
domen> http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for
domen> details
>> It's ugly and really serves no purpose except for obfuscation.

Matthew> We've had drivers with typos.  Missing one f suddenly causes
Matthew> all your memory to come from ZONE_DMA.  Having an extra f
Matthew> causes your driver to work ... most of the time on machines
Matthew> with >4GB ram.  Sure, your driver doesn't, but when looking
Matthew> over a lot of drivers, it's easier if everyone's using the
Matthew> same macros.

If these were the only two masks ever used I'd agree with you. However
there's several other in use and more will probably be added, so we're
going to end up with drivers sometimes using constants and other times
hex values causing an even bigger mess ;-(

Cheers,
Jes