From: Jes Sorensen <jes@wildopensource.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org, akpm@osdl.org,
James.Bottomley@steeleye.com, jeremy@sgi.com
Subject: Re: [patch] qla1280 update for 2.6.1-mm4
Date: 19 Jan 2004 07:27:07 -0500 [thread overview]
Message-ID: <yq0znck6s4k.fsf@wildopensource.com> (raw)
In-Reply-To: <20040119121406.A32409@infradead.org>
>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
Christoph> On Mon, Jan 19, 2004 at 07:08:04AM -0500, Jes Sorensen
Christoph> wrote:
>> +#ifdef QLA_64BIT_PTR static int qla1280_64bit_start_scsi(struct
>> scsi_qla_host *, struct srb *); +#else static int
>> qla1280_32bit_start_scsi(struct scsi_qla_host *, struct srb *);
>> +#endif
Christoph> Shouldn't you just call both of those qla1280_start_scsi if
Christoph> only one of them is compiled at a time anyway?
I was actually thinking about merging them into one function since
they are 98% identical at the moment. However doing so requires more
testing and I'd like to get the obviously correct stuff out to the
users asap, including the big endian changes James posted.
So yes I agree, but thats qla1280 v3.25 material. Hopefully very soon
;-)
Cheers,
Jes
next prev parent reply other threads:[~2004-01-19 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-19 12:08 [patch] qla1280 update for 2.6.1-mm4 Jes Sorensen
2004-01-19 12:14 ` Christoph Hellwig
2004-01-19 12:27 ` Jes Sorensen [this message]
2004-01-19 17:03 ` James Bottomley
2004-01-19 21:18 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0znck6s4k.fsf@wildopensource.com \
--to=jes@wildopensource.com \
--cc=James.Bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=jeremy@sgi.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox