From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Deepak Ukey <deepak.ukey@microchip.com>,
Jack Wang <jinpu.wang@cloud.ionos.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Radha Ramachandran <radha@google.com>,
Viswas G <Viswas.G@microchip.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: pm8001: Fix error code in non_fatal_log_show()
Date: Mon, 01 Jun 2026 21:52:52 -0400 [thread overview]
Message-ID: <yq11pepaeul.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <ahs-bEsBJH0KhnsX@stanley.mountain> (Dan Carpenter's message of "Sat, 30 May 2026 22:45:48 +0300")
Dan,
> The non_fatal_log_show() function is supposed to return negative error
> codes on failure. But because the error codes are saved in a u32 and
> then cast to signed long, they end up being high positive values
> instead of negative. Remove the intermediary u32 variable to fix this
> bug.
Applied to 7.2/scsi-staging, thanks!
--
Martin K. Petersen
next prev parent reply other threads:[~2026-06-02 1:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 19:45 [PATCH] scsi: pm8001: Fix error code in non_fatal_log_show() Dan Carpenter
2026-06-01 4:59 ` Jinpu Wang
2026-06-02 1:52 ` Martin K. Petersen [this message]
2026-06-09 1:39 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11pepaeul.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Viswas.G@microchip.com \
--cc=deepak.ukey@microchip.com \
--cc=error27@gmail.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=radha@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox