From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christian Heusel <christian@heusel.eu>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Daejun Park <daejun7.park@samsung.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Damien Le Moal <dlemoal@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
regressions@lists.linux.dev
Subject: Re: [PATCH v9 11/19] scsi: sd: Translate data lifetime information
Date: Tue, 11 Jun 2024 21:48:48 -0400 [thread overview]
Message-ID: <yq11q53ylsw.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <9dae2056-792a-4bd0-ab1d-6c545ec781b9@acm.org> (Bart Van Assche's message of "Tue, 11 Jun 2024 16:08:44 -0700")
Hi Bart!
> diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
> index b31464740f6c..9a7185c68872 100644
> --- a/drivers/usb/storage/scsiglue.c
> +++ b/drivers/usb/storage/scsiglue.c
> @@ -79,6 +79,8 @@ static int slave_alloc (struct scsi_device *sdev)
> if (us->protocol == USB_PR_BULK && us->max_lun > 0)
> sdev->sdev_bflags |= BLIST_FORCELUN;
>
> + sdev->sdev_bflags |= BLIST_SKIP_IO_HINTS;
> +
I suspect this is the safest approach and prefer it over the individual
device quirk.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-06-12 1:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 21:48 [PATCH v9 00/19] Pass data lifetime information to SCSI disk devices Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 01/19] fs: Fix rw_hint validation Bart Van Assche
2024-01-31 13:56 ` Christian Brauner
2024-01-31 21:07 ` Bart Van Assche
2024-02-22 2:46 ` Bart Van Assche
2024-02-22 8:51 ` Christian Brauner
2024-01-31 14:51 ` Kanchan Joshi
2024-01-30 21:48 ` [PATCH v9 02/19] fs: Verify write lifetime constants at compile time Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 03/19] fs: Split fcntl_rw_hint() Bart Van Assche
2024-01-31 14:52 ` Kanchan Joshi
2024-01-30 21:48 ` [PATCH v9 04/19] fs: Move enum rw_hint into a new header file Bart Van Assche
2024-01-31 7:48 ` Chao Yu
2024-01-30 21:48 ` [PATCH v9 05/19] fs: Propagate write hints to the struct block_device inode Bart Van Assche
2024-01-31 14:55 ` Kanchan Joshi
2024-01-30 21:48 ` [PATCH v9 06/19] block, fs: Restore the per-bio/request data lifetime fields Bart Van Assche
2024-01-31 14:55 ` Kanchan Joshi
2024-01-30 21:48 ` [PATCH v9 07/19] fs/f2fs: Restore the whint_mode mount option Bart Van Assche
2024-02-01 10:27 ` Chao Yu
2024-01-30 21:48 ` [PATCH v9 08/19] fs/f2fs: Restore support for tracing data lifetimes Bart Van Assche
2024-02-01 10:27 ` Chao Yu
2024-01-30 21:48 ` [PATCH v9 09/19] scsi: core: Query the Block Limits Extension VPD page Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 10/19] scsi: scsi_proto: Add structures and constants related to I/O groups and streams Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 11/19] scsi: sd: Translate data lifetime information Bart Van Assche
2024-02-15 21:33 ` Martin K. Petersen
2024-02-15 21:51 ` Bart Van Assche
2024-02-15 22:00 ` Martin K. Petersen
2024-02-16 0:22 ` Bart Van Assche
2024-02-16 0:32 ` Martin K. Petersen
2024-06-11 20:57 ` Andy Shevchenko
2024-06-11 21:21 ` Christian Heusel
2024-06-11 23:08 ` Bart Van Assche
2024-06-12 1:48 ` Martin K. Petersen [this message]
2024-06-12 5:35 ` Andy Shevchenko
2024-06-12 5:42 ` Andy Shevchenko
2024-01-30 21:48 ` [PATCH v9 12/19] scsi: scsi_debug: Reduce code duplication Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 13/19] scsi: scsi_debug: Support the block limits extension VPD page Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 14/19] scsi: scsi_debug: Rework page code error handling Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 15/19] scsi: scsi_debug: Rework subpage " Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 16/19] scsi: scsi_debug: Allocate the MODE SENSE response from the heap Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 17/19] scsi: scsi_debug: Implement the IO Advice Hints Grouping mode page Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 18/19] scsi: scsi_debug: Implement GET STREAM STATUS Bart Van Assche
2024-01-30 21:48 ` [PATCH v9 19/19] scsi: scsi_debug: Maintain write statistics per group number Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11q53ylsw.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=andy.shevchenko@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=christian@heusel.eu \
--cc=daejun7.park@samsung.com \
--cc=dlemoal@kernel.org \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox