From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Steffen Maier <maier@linux.ibm.com>
Cc: "James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
Benjamin Block <bblock@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH] zfcp: fix missing auto port scan and thus missing target ports
Date: Mon, 01 Aug 2022 19:50:18 -0400 [thread overview]
Message-ID: <yq11qtz4j83.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220729162529.1620730-1-maier@linux.ibm.com> (Steffen Maier's message of "Fri, 29 Jul 2022 18:25:29 +0200")
Steffen,
> Case (1): The only waiter on wka_port->completion_wq is
> zfcp_fc_wka_port_get() trying to open a WKA port. As such it should
> only be woken up by WKA port *open* responses, not by WKA port close
> responses.
>
> Case (2): A close WKA port response coming in just after having sent a
> new open WKA port request and before blocking for the open response
> with wait_event() in zfcp_fc_wka_port_get() erroneously renders the
> wait_event a NOP because the close handler overwrites
> wka_port->status. Hence the wait_event condition is erroneously true
> and it does not enter blocking state.
Applied to 5.20/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2022-08-01 23:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 16:25 [PATCH] zfcp: fix missing auto port scan and thus missing target ports Steffen Maier
2022-08-01 23:50 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11qtz4j83.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bblock@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox