* [PATCH] megaraid: fix error check return value of register_chrdev()
@ 2022-04-18 10:57 cgel.zte
2022-04-26 13:03 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2022-04-18 10:57 UTC (permalink / raw)
To: kashyap.desai, sumit.saxena
Cc: shivasharan.srikanteshwara, jejb, martin.petersen,
megaraidlinux.pdl, linux-scsi, linux-kernel, Lv Ruyi, Zeal Robot
From: Lv Ruyi <lv.ruyi@zte.com.cn>
If major equal 0, register_chrdev() returns error code when it fails.
This function dynamically allocate a major and return its number on
success, so we should use "< 0" to check it instead of "!".
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
drivers/scsi/megaraid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index a5d8cee2d510..bf491af9f0d6 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -4607,7 +4607,7 @@ static int __init megaraid_init(void)
* major number allocation.
*/
major = register_chrdev(0, "megadev_legacy", &megadev_fops);
- if (!major) {
+ if (major < 0) {
printk(KERN_WARNING
"megaraid: failed to register char device\n");
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] megaraid: fix error check return value of register_chrdev()
2022-04-18 10:57 [PATCH] megaraid: fix error check return value of register_chrdev() cgel.zte
@ 2022-04-26 13:03 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-04-26 13:03 UTC (permalink / raw)
To: cgel.zte
Cc: kashyap.desai, sumit.saxena, shivasharan.srikanteshwara, jejb,
martin.petersen, megaraidlinux.pdl, linux-scsi, linux-kernel,
Lv Ruyi, Zeal Robot
> If major equal 0, register_chrdev() returns error code when it fails.
> This function dynamically allocate a major and return its number on
> success, so we should use "< 0" to check it instead of "!".
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] megaraid: fix error check return value of register_chrdev()
2022-04-18 10:57 [PATCH] megaraid: fix error check return value of register_chrdev() cgel.zte
2022-04-26 13:03 ` Martin K. Petersen
@ 2022-05-03 0:51 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-05-03 0:51 UTC (permalink / raw)
To: cgel.zte, kashyap.desai, sumit.saxena
Cc: Martin K . Petersen, megaraidlinux.pdl, linux-kernel, jejb,
Zeal Robot, shivasharan.srikanteshwara, Lv Ruyi, linux-scsi
On Mon, 18 Apr 2022 10:57:55 +0000, cgel.zte@gmail.com wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> If major equal 0, register_chrdev() returns error code when it fails.
> This function dynamically allocate a major and return its number on
> success, so we should use "< 0" to check it instead of "!".
>
>
> [...]
Applied to 5.19/scsi-queue, thanks!
[1/1] megaraid: fix error check return value of register_chrdev()
https://git.kernel.org/mkp/scsi/c/c5acd61dbb32
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-04 7:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-18 10:57 [PATCH] megaraid: fix error check return value of register_chrdev() cgel.zte
2022-04-26 13:03 ` Martin K. Petersen
2022-05-03 0:51 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox