public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Sven Schnelle <svens@stackframe.org>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani  <suganath-prabu.subramani@broadcom.com>,
	MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
	Helge Deller <deller@gmx.de>
Subject: Re: [PATCH] mpt3sas: add NULL check in _base_fault_reset_work()
Date: Wed, 20 Oct 2021 23:08:29 -0400	[thread overview]
Message-ID: <yq11r4f84er.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20211019191208.6546-1-svens@stackframe.org> (Sven Schnelle's message of "Tue, 19 Oct 2021 21:12:08 +0200")


Sven,

> My HP C8000 (an PA-RISC based system) crashed with an HPMC. That
> triggered the HPMC handler in the kernel, and i got a crash in
> _base_fault_reset_work() from mpt3sas. It looks like this function
> calls ioc->schedule_dead_ioc_flush_running_cmds() without checking
> whether there's actually a function set, so it dereferences a NULL
> pointer on that system. The c8000 actually uses the mptspi driver
> instead of mpt3sas which doesn't seem to set this handler.

I'm not sure how you end up in the mpt3sas driver if your system uses
mptspi!?

Can you please send us the HPMC and the output of lspci?

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2021-10-21  3:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 19:12 [PATCH] mpt3sas: add NULL check in _base_fault_reset_work() Sven Schnelle
2021-10-21  3:08 ` Martin K. Petersen [this message]
2021-10-21  5:40   ` Sven Schnelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq11r4f84er.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=deller@gmx.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sathya.prakash@broadcom.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    --cc=svens@stackframe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox