From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Roman Bolshakov <r.bolshakov@yadro.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
<linux-scsi@vger.kernel.org>, Nilesh Javali <njavali@marvell.com>,
Himanshu Madhani <hmadhani@marvell.com>,
Quinn Tran <qutran@marvell.com>, Martin Wilck <mwilck@suse.com>,
Daniel Wagner <dwagner@suse.de>
Subject: Re: [PATCH] qla2xxx: Increase the size of struct qla_fcp_prio_cfg to FCP_PRIO_CFG_SIZE
Date: Mon, 13 Apr 2020 22:24:37 -0400 [thread overview]
Message-ID: <yq11roqu7mi.fsf@oracle.com> (raw)
In-Reply-To: <20200413153049.GA8042@SPB-NB-133.local> (Roman Bolshakov's message of "Mon, 13 Apr 2020 18:30:49 +0300")
Roman,
>> - struct qla_fcp_prio_entry entry[1]; /* fcp priority entries */
>> + struct qla_fcp_prio_entry entry[1023]; /* fcp priority entries */
>> #define FCP_PRIO_CFG_ENTRY_SIZE 0x20
>> + uint8_t reserved2[16];
>> };
>>
>> #define FCP_PRIO_CFG_SIZE (32*1024) /* fcp prio data per port*/
>
> A new constant may be introduced to define size of qla_fcp_prio_entry.
> That would let to drop the magic 32 number here and allow to add one
> more BUILD_BUG_ON for sizeof(struct qla_fcp_prio_entry).
I agree that additional sanity testing here would be nice.
I wonder what the firmware interface says about the runt entry?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-04-14 2:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-05 23:13 [PATCH] qla2xxx: Increase the size of struct qla_fcp_prio_cfg to FCP_PRIO_CFG_SIZE Bart Van Assche
2020-04-06 7:39 ` Daniel Wagner
2020-04-06 14:54 ` Himanshu Madhani
2020-04-13 15:30 ` Roman Bolshakov
2020-04-14 2:24 ` Martin K. Petersen [this message]
2020-04-14 11:49 ` Roman Bolshakov
2020-04-14 3:56 ` Bart Van Assche
2020-04-14 11:45 ` Roman Bolshakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11roqu7mi.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=dwagner@suse.de \
--cc=hmadhani@marvell.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mwilck@suse.com \
--cc=njavali@marvell.com \
--cc=qutran@marvell.com \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox