linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Laurence Oberman <loberman@redhat.com>
Cc: djeffery@redhat.com, cdupuis1@gmail.com, lduncan@suse.com,
	martin.petersen@oracle.com, QLogic-Storage-Upstream@qlogic.com,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] bnx2fc: Handle scope bits when array returns BUSY or TASK_SET_FULL
Date: Mon, 23 Sep 2019 22:19:51 -0400	[thread overview]
Message-ID: <yq11rw65tbs.fsf@oracle.com> (raw)
In-Reply-To: <1568210202-12794-1-git-send-email-loberman@redhat.com> (Laurence Oberman's message of "Wed, 11 Sep 2019 09:56:42 -0400")


Laurence,

> The qla2xxx driver had this issue as well when the newer array
> firmware returned the retry_delay_timer in the fcp_rsp.
> The bnx2fc is not handling the masking of the scope bits either
> so the retry_delay_timestamp value lands up being a large value
> added to the timer timestamp delaying I/O for up to 27 Minutes.
> This patch adds similar code to handle this to the
> bnx2fc driver to avoid the huge delay.
> ---
> V2. Fix Indent for comments (Chad)
> V3. Kbuild robot reported uninitialized variable scope
>     Initialize scope to 0
>
> Signed-off-by: Laurence Oberman <loberman@redhat.com>
> Reported-by: David Jeffery <djeffery@redhat.com>
> Reported-by: kbuild test robot <lkp@intel.com>
> ---
>  drivers/scsi/bnx2fc/bnx2fc_io.c | 29 ++++++++++++++++++++++++-----
>  1 file changed, 24 insertions(+), 5 deletions(-)

Applied to 5.4/scsi-fixes.

Please read Documentation/process/submitting-patches.rst. Your patch got
all mangled since you put tags after the --- separator.

Also, please use the -vN option when submitting updated patches.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2019-09-24  2:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 13:56 [PATCH] bnx2fc: Handle scope bits when array returns BUSY or TASK_SET_FULL Laurence Oberman
2019-09-24  2:19 ` Martin K. Petersen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-09-09 12:05 Laurence Oberman
2019-09-09 17:40 ` Lee Duncan
2019-09-11  0:19 ` cdupuis1
2019-09-11  2:21 ` Martin K. Petersen
2019-09-06 20:26 Laurence Oberman
2019-09-06 20:31 ` Laurence Oberman
2019-09-08  1:34 ` cdupuis1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq11rw65tbs.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=QLogic-Storage-Upstream@qlogic.com \
    --cc=cdupuis1@gmail.com \
    --cc=djeffery@redhat.com \
    --cc=lduncan@suse.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=loberman@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).