From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH V6 2/4] block: Kill gfp_t argument of blkdev_report_zones() Date: Thu, 11 Jul 2019 20:24:18 -0400 Message-ID: References: <20190701050918.27511-1-damien.lemoal@wdc.com> <20190701050918.27511-3-damien.lemoal@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190701050918.27511-3-damien.lemoal@wdc.com> (Damien Le Moal's message of "Mon, 1 Jul 2019 14:09:16 +0900") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Damien Le Moal Cc: Jens Axboe , "Martin K . Petersen" , Mike Snitzer , linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-scsi@vger.kernel.org, Jaegeuk Kim , Christoph Hellwig , Bart Van Assche List-Id: linux-scsi@vger.kernel.org Damien, > Only GFP_KERNEL and GFP_NOIO are used with blkdev_report_zones(). In > preparation of using vmalloc() for large report buffer and zone array > allocations used by this function, remove its "gfp_t gfp_mask" argument > and rely on the caller context to use memalloc_noio_save/restore() where > necessary (block layer zone revalidation and dm-zoned I/O error path). LGTM. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering