From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Matthew Wilcox <matthew@wil.cx>, Hannes Reinecke <hare@suse.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: advansys: Remove unnecessary parentheses
Date: Thu, 20 Sep 2018 23:11:59 -0400 [thread overview]
Message-ID: <yq11s9nmtmo.fsf@oracle.com> (raw)
In-Reply-To: <20180920205858.6035-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Thu, 20 Sep 2018 13:58:58 -0700")
Nathan,
> Clang warns when multiple pairs of parentheses are used for a single
> conditional statement.
>
> drivers/scsi/advansys.c:6451:20: warning: equality comparison with
> extraneous parentheses [-Wparentheses-equality]
> if ((sdtr_data == 0xFF)) {
> ~~~~~~~~~~^~~~~~~
> drivers/scsi/advansys.c:6451:20: note: remove extraneous parentheses
> around the comparison to silence this warning
> if ((sdtr_data == 0xFF)) {
> ~ ^ ~
> drivers/scsi/advansys.c:6451:20: note: use '=' to turn this equality
> comparison into an assignment
> if ((sdtr_data == 0xFF)) {
> ^~
> =
> 1 warning generated.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-09-21 3:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 20:58 [PATCH] scsi: advansys: Remove unnecessary parentheses Nathan Chancellor
2018-09-21 3:11 ` Martin K. Petersen [this message]
2018-09-21 5:57 ` Hannes Reinecke
2018-09-26 0:48 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11s9nmtmo.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox