* [PATCH] scsi: advansys: Remove unnecessary parentheses
@ 2018-09-20 20:58 Nathan Chancellor
2018-09-21 3:11 ` Martin K. Petersen
2018-09-21 5:57 ` Hannes Reinecke
0 siblings, 2 replies; 4+ messages in thread
From: Nathan Chancellor @ 2018-09-20 20:58 UTC (permalink / raw)
To: Matthew Wilcox, Hannes Reinecke, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, linux-kernel, Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single
conditional statement.
drivers/scsi/advansys.c:6451:20: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
if ((sdtr_data == 0xFF)) {
~~~~~~~~~~^~~~~~~
drivers/scsi/advansys.c:6451:20: note: remove extraneous parentheses
around the comparison to silence this warning
if ((sdtr_data == 0xFF)) {
~ ^ ~
drivers/scsi/advansys.c:6451:20: note: use '=' to turn this equality
comparison into an assignment
if ((sdtr_data == 0xFF)) {
^~
=
1 warning generated.
Link: https://github.com/ClangBuiltLinux/linux/issues/155
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/scsi/advansys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 713f69033f20..44c96199e00a 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -6448,7 +6448,7 @@ static void AscIsrChipHalted(ASC_DVC_VAR *asc_dvc)
sdtr_data =
AscCalSDTRData(asc_dvc, ext_msg.xfer_period,
ext_msg.req_ack_offset);
- if ((sdtr_data == 0xFF)) {
+ if (sdtr_data == 0xFF) {
q_cntl |= QC_MSG_OUT;
asc_dvc->init_sdtr &= ~target_id;
--
2.19.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: advansys: Remove unnecessary parentheses
2018-09-20 20:58 [PATCH] scsi: advansys: Remove unnecessary parentheses Nathan Chancellor
@ 2018-09-21 3:11 ` Martin K. Petersen
2018-09-21 5:57 ` Hannes Reinecke
1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2018-09-21 3:11 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Matthew Wilcox, Hannes Reinecke, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel
Nathan,
> Clang warns when multiple pairs of parentheses are used for a single
> conditional statement.
>
> drivers/scsi/advansys.c:6451:20: warning: equality comparison with
> extraneous parentheses [-Wparentheses-equality]
> if ((sdtr_data == 0xFF)) {
> ~~~~~~~~~~^~~~~~~
> drivers/scsi/advansys.c:6451:20: note: remove extraneous parentheses
> around the comparison to silence this warning
> if ((sdtr_data == 0xFF)) {
> ~ ^ ~
> drivers/scsi/advansys.c:6451:20: note: use '=' to turn this equality
> comparison into an assignment
> if ((sdtr_data == 0xFF)) {
> ^~
> =
> 1 warning generated.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: advansys: Remove unnecessary parentheses
2018-09-20 20:58 [PATCH] scsi: advansys: Remove unnecessary parentheses Nathan Chancellor
2018-09-21 3:11 ` Martin K. Petersen
@ 2018-09-21 5:57 ` Hannes Reinecke
2018-09-26 0:48 ` Martin K. Petersen
1 sibling, 1 reply; 4+ messages in thread
From: Hannes Reinecke @ 2018-09-21 5:57 UTC (permalink / raw)
To: Nathan Chancellor, Matthew Wilcox, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, linux-kernel
On 9/20/18 10:58 PM, Nathan Chancellor wrote:
> Clang warns when multiple pairs of parentheses are used for a single
> conditional statement.
>
> drivers/scsi/advansys.c:6451:20: warning: equality comparison with
> extraneous parentheses [-Wparentheses-equality]
> if ((sdtr_data == 0xFF)) {
> ~~~~~~~~~~^~~~~~~
> drivers/scsi/advansys.c:6451:20: note: remove extraneous parentheses
> around the comparison to silence this warning
> if ((sdtr_data == 0xFF)) {
> ~ ^ ~
> drivers/scsi/advansys.c:6451:20: note: use '=' to turn this equality
> comparison into an assignment
> if ((sdtr_data == 0xFF)) {
> ^~
> =
> 1 warning generated.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/155
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/scsi/advansys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
> index 713f69033f20..44c96199e00a 100644
> --- a/drivers/scsi/advansys.c
> +++ b/drivers/scsi/advansys.c
> @@ -6448,7 +6448,7 @@ static void AscIsrChipHalted(ASC_DVC_VAR *asc_dvc)
> sdtr_data =
> AscCalSDTRData(asc_dvc, ext_msg.xfer_period,
> ext_msg.req_ack_offset);
> - if ((sdtr_data == 0xFF)) {
> + if (sdtr_data == 0xFF) {
>
> q_cntl |= QC_MSG_OUT;
> asc_dvc->init_sdtr &= ~target_id;
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.com +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-26 0:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-20 20:58 [PATCH] scsi: advansys: Remove unnecessary parentheses Nathan Chancellor
2018-09-21 3:11 ` Martin K. Petersen
2018-09-21 5:57 ` Hannes Reinecke
2018-09-26 0:48 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox