From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: Nicolas Iooss <nicolas.iooss_linux@m4x.org>,
GOTO Masanori <gotom@debian.or.jp>,
YOKOTA Hiroshi <yokota@netlab.is.tsukuba.ac.jp>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: nsp32: add __printf attribute to logging functions
Date: Tue, 23 May 2017 22:02:07 -0400 [thread overview]
Message-ID: <yq11srfxba8.fsf@oracle.com> (raw)
In-Reply-To: <1495280136.27714.6.camel@perches.com> (Joe Perches's message of "Sat, 20 May 2017 04:35:36 -0700")
Joe,
> On Sat, 2017-05-20 at 13:16 +0200, Nicolas Iooss wrote:
>> nsp32_message() and nsp32_dmessage() use printf format strings in order
>> to format a message. Adding __printf attributes helps to detect errors
>> in such format strings at build time, like:
> Does anyone actually have or use these cards any longer?
I doubt it.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-05-24 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 11:16 [PATCH 1/2] scsi: nsp32: add __printf attribute to logging functions Nicolas Iooss
2017-05-20 11:16 ` [PATCH 2/2] pcmcia: nsp_cs: " Nicolas Iooss
2017-05-20 11:35 ` [PATCH 1/2] scsi: nsp32: " Joe Perches
2017-05-24 2:02 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq11srfxba8.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=gotom@debian.or.jp \
--cc=jejb@linux.vnet.ibm.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
--cc=yokota@netlab.is.tsukuba.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox