* [PATCH] scsi: stex: make S6flag static
@ 2017-04-25 17:36 Colin King
2017-04-26 2:40 ` Charles Chiou
2017-04-26 22:33 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-04-25 17:36 UTC (permalink / raw)
To: Charles, James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
This module specific flag can be made static as it does
not need to be in global scope.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/stex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
index 0751561b59da..9b20643ab49d 100644
--- a/drivers/scsi/stex.c
+++ b/drivers/scsi/stex.c
@@ -363,7 +363,7 @@ struct st_card_info {
u16 sts_count;
};
-int S6flag;
+static int S6flag;
static int stex_halt(struct notifier_block *nb, ulong event, void *buf);
static struct notifier_block stex_notifier = {
stex_halt, NULL, 0
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: stex: make S6flag static
2017-04-25 17:36 [PATCH] scsi: stex: make S6flag static Colin King
@ 2017-04-26 2:40 ` Charles Chiou
2017-04-26 22:33 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Charles Chiou @ 2017-04-26 2:40 UTC (permalink / raw)
To: Colin King, Charles, James E . J . Bottomley, Martin K . Petersen,
linux-scsi
Cc: linux-kernel, Promise_Linux
Looks good to me.
Thanks for the improvement.
On 4/26/2017 1:36 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> This module specific flag can be made static as it does
> not need to be in global scope.
>
> Reviewed-by: Charles Chiou <charles.chiou@tw.promise.com>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/stex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/stex.c b/drivers/scsi/stex.c
> index 0751561b59da..9b20643ab49d 100644
> --- a/drivers/scsi/stex.c
> +++ b/drivers/scsi/stex.c
> @@ -363,7 +363,7 @@ struct st_card_info {
> u16 sts_count;
> };
>
> -int S6flag;
> +static int S6flag;
> static int stex_halt(struct notifier_block *nb, ulong event, void *buf);
> static struct notifier_block stex_notifier = {
> stex_halt, NULL, 0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: stex: make S6flag static
2017-04-25 17:36 [PATCH] scsi: stex: make S6flag static Colin King
2017-04-26 2:40 ` Charles Chiou
@ 2017-04-26 22:33 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-04-26 22:33 UTC (permalink / raw)
To: Colin King
Cc: Charles, James E . J . Bottomley, Martin K . Petersen, linux-scsi,
linux-kernel
Colin,
> This module specific flag can be made static as it does not need to be
> in global scope.
Applied to 4.12/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-26 22:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-25 17:36 [PATCH] scsi: stex: make S6flag static Colin King
2017-04-26 2:40 ` Charles Chiou
2017-04-26 22:33 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox